Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemz does not use new € sign #18

Closed
sur5r opened this issue Nov 3, 2017 · 6 comments
Closed

itemz does not use new € sign #18

sur5r opened this issue Nov 3, 2017 · 6 comments
Labels

Comments

@sur5r
Copy link
Member

sur5r commented Nov 3, 2017

I just updated the floppy with current master and found itemz not to be using the new € sign. I have no time to fix it myself, though.

@sur5r sur5r added the bug label Nov 3, 2017
@stapelberg
Copy link
Member

This is what it looks like to me right now:

itemz

Is that not the correct € sign? It looks the same to me like in the kasse main program.

@sur5r
Copy link
Member Author

sur5r commented Jun 10, 2022

Maybe this behaves inconsistently for some reason on real hardware. Will have to try.

@stapelberg
Copy link
Member

Ah, I think the problem might be that the itemz program does not call

vdc_patch_charset();
when starting.

When autostarting the kasse disk image (like we do in make vice), the character set is modified and that influences the itemz program, too.

But, when changing -autostart kasse.d71 to -8 kasse.d71 and running run"itemz, I see a broken euro symbol indeed:
euro

I have been thinking about merging itemz into kasse, so that we only need the one program. Was there any reason against that, or have we just never gotten around to doing it? (We did something similar for the credit manager AFAIR.)

@sur5r
Copy link
Member Author

sur5r commented Jun 10, 2022

I think we simply never got around to it. Also, modifying items while running kasse could have interesting side effects. The data model also does not cope with prices changing over time. At least the sum is going to be wrong.

@stapelberg
Copy link
Member

I think commit 62aba6c should do it :)

We’re re-loading the items file after running the itemz_manager() function.

@sur5r
Copy link
Member Author

sur5r commented Jun 10, 2022

Makes sense at a first glance. Should be tested before the event, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants