Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements we may want to make to the code #14

Closed
4 of 11 tasks
RoyStegeman opened this issue Jun 21, 2022 · 1 comment
Closed
4 of 11 tasks

Some improvements we may want to make to the code #14

RoyStegeman opened this issue Jun 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@RoyStegeman
Copy link
Member

RoyStegeman commented Jun 21, 2022

  • Make the name of the fit output folder the same as the name of the runcard instead of "fits"
  • Make code more user-friendly by storing info in dataclass objects instead of dicts
  • Make a default folder to store the fits, so the path doesn't need to be passed each time plots are made
  • Make a single interface for all plots
  • Add the option to either use patience_epochs or patience_fraction to the runcard. Current stopping_patience is in epochs, which is different from n3fit where it's a fraction, this might lead to confusion
  • add a generate_pseudodata boolean flag option to the fit runcard
  • Make names in callbacks.py more sensible
  • do feature scaling outside model, this will also affect how models are saves/loaded
  • Stop rich from messing with ipdb
  • related to above, just print chi2 info line-by-line so the logs contain a history
  • make gradient descent stochastic to reduce computational costs
@Radonirinaunimi
Copy link
Member

Closing this as most of the points are no longer applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants