Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rocoto_viewer to allow entities #15

Open
WalterKolczynski-NOAA opened this issue Jul 7, 2021 · 0 comments · May be fixed by #16
Open

Update rocoto_viewer to allow entities #15

WalterKolczynski-NOAA opened this issue Jul 7, 2021 · 0 comments · May be fixed by #16
Assignees
@WalterKolczynski-NOAA
Labels
enhancement New feature or request

Comments

@WalterKolczynski-NOAA
Copy link
Collaborator

GEFS divides the workflow up by task using entities. The XML parser currently used by rocoto_viewer does not allow this.

The GEFS team already has an untracked (or, at least, non-CROW) version that has fixed this issue. Those changes just need to be brought over into CROW.
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the enhancement New feature or request label Jul 7, 2021
@WalterKolczynski-NOAA WalterKolczynski-NOAA self-assigned this Jul 7, 2021
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/CROW that referenced this issue Jul 7, 2021
@WalterKolczynski-NOAA
Add in GEFS updates to rocoto_viewer
9109c7f 
There are some changes to rocoto_viewer that were made elsewhere
for GEFS that are now brought back into CROW. Primary of these is
updating the XML parser from xml to lxml to allow workflow files
that are split into pieces using entities. The other changes are
abstracting the max job-length name to a variable and changing the
header string.

Refs: NOAA-EMC#15
@WalterKolczynski-NOAA WalterKolczynski-NOAA linked a pull request Jul 12, 2021 that will close this issue
Open
@WalterKolczynski-NOAA WalterKolczynski-NOAA linked a pull request Jul 12, 2021 that will close this issue
Update rocoto_viewer to python3 #16
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WalterKolczynski-NOAA WalterKolczynski-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update rocoto_viewer to python3 WalterKolczynski-NOAA/CROW
1 participant
@WalterKolczynski-NOAA