-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PE_MEMBER logic that is no longer relevant #103
Comments
In one of the future commits we will remove |
@DusanJovic-NOAA I like the simplicity of this. NEMS is getting very small. This is basically just the unified driver now. @theurich @mark-a-potts |
The PE_MEMBER logic in NEMS and the model_configure is no longer relevant and should be removed. This remains historically from a prior version of NEMS that supported ensembles in the same MPI world.
See here:
NEMS/src/module_NEMS_GRID_COMP.F90
Line 279 in b593c6c
and here:
NEMS/src/module_NEMS_GRID_COMP.F90
Line 308 in b593c6c
In all cases now, the NEMS EARTH DRIVER runs across all PETs and so specification of the petList parameter to ESMF_GridCompCreate() is not required.
The recommended approach is to remove all PE_MEMBER logic from NEMS.
This also allows for removal of
PE_MEMBER01:
insidemodel_configure
. Its presence there is confusing anyway since that file is a config file for the atmosphere, and not the overall NEMS level.The text was updated successfully, but these errors were encountered: