Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PE_MEMBER logic that is no longer relevant #103

Closed
rsdunlapiv opened this issue Jun 16, 2021 · 4 comments · Fixed by #104
Closed

Remove PE_MEMBER logic that is no longer relevant #103

rsdunlapiv opened this issue Jun 16, 2021 · 4 comments · Fixed by #104

Comments

@rsdunlapiv
Copy link

The PE_MEMBER logic in NEMS and the model_configure is no longer relevant and should be removed. This remains historically from a prior version of NEMS that supported ensembles in the same MPI world.

See here:

CALL ESMF_ConfigGetAttribute(config = CF_NEMS &

and here:

,petlist = PETLIST(1:PE_MEMBER) & !<-- Element I's PE list

In all cases now, the NEMS EARTH DRIVER runs across all PETs and so specification of the petList parameter to ESMF_GridCompCreate() is not required.

The recommended approach is to remove all PE_MEMBER logic from NEMS.

This also allows for removal of PE_MEMBER01: inside model_configure. Its presence there is confusing anyway since that file is a config file for the atmosphere, and not the overall NEMS level.

@rsdunlapiv
Copy link
Author

@DusanJovic-NOAA
Copy link
Collaborator

In one of the future commits we will remove module_NEMS_GRID_COMP.F90 entirely. It does nothing except instantiate Earth Grid Comp, which can be done directly in the main program.
This is the version of the main program that calls Earth Grid Comp directly.
MAIN_NEMS.F90.txt
It still reads PE_MEMBER01 which I just moved from NEMS Grid comp. It should be removed.

@DusanJovic-NOAA
Copy link
Collaborator

@rsdunlapiv
Copy link
Author

@DusanJovic-NOAA I like the simplicity of this. NEMS is getting very small. This is basically just the unified driver now. @theurich @mark-a-potts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants