Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the field_table yaml format #1520

Closed
4 tasks
uramirez8707 opened this issue May 14, 2024 · 0 comments · Fixed by #1519
Closed
4 tasks

Update the field_table yaml format #1520

uramirez8707 opened this issue May 14, 2024 · 0 comments · Fixed by #1519
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.

Comments

@uramirez8707
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current version of the field table yaml is this:

field_table:
- field_type: tracer
  modlist:
  - model_type: atmos_mod
    varlist:
    - variable: sphum
      longname: specific humidity
      units: kg/kg
      profile_type: fixed
      subparams:
      - surface_value: 3.0e-06
    - variable: soa
      longname: SOA tracer
      units: mmr
      convection: all
      chem_param: aerosol
      subparams:
      - frac_pm1: 0.89
        frac_pm25: 0.96
        frac_pm10: 1.0
      profile_type: fixed
      subparams:
      - surface_value: 1.0e-32

The problem with this is that it is not very clear for looking at the table that surface_value is a subparams of profile_type or that frac_pm1, frac_pm25, and frac_pm10 are subparams of chem_param.

It is also not possible to add a schema with this format.

Thus we will like the table to be updated to

field_table:
- field_type: tracer
  modlist:
  - model_type: atmos_mod
    varlist:
    - variable: sphum
      longname: specific humidity
      units: kg/kg
      profile_type:
      - value: fixed
        surface_value: 3.0e-06
    - variable: soa
      longname: SOA tracer
      units: mmr
      convection: all
      chem_param:
      - value: aerosol
        frac_pm1: 0.89
        frac_pm25: 0.96
        frac_pm10: 1.0
      profile_type:
      - value: fixed
        surface_value: 1.0e-32

Describe the solution you'd like

Describe alternatives you've considered
N/A

Additional context
N/A

@uramirez8707 uramirez8707 added the enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR for a modification that increases performance, improves syntax, or adds functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant