Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning on all the new bug-fix options makes ice-ocean model blow up #707

Closed
kshedstrom opened this issue Aug 7, 2024 · 13 comments
Closed

Comments

@kshedstrom
Copy link

It is blowing up with ice velocities out of bounds in the first month. An example of sispeed is here. Notable is some hint of the tile boundaries which are ten grids apart in x. At @theresa-morrison's suggestion, I turned off all the new OM4_SUBCELLS options and it is running longer.
Screenshot 2024-08-07 at 2 31 05 PM

@kshedstrom
Copy link
Author

No, it still looks like crap, including the tile hints. It must be one of the other new changes.

@kshedstrom
Copy link
Author

kshedstrom commented Aug 8, 2024

OK, following the usual DEBUG comparison of 4x6 cores vs 3x7 gives:

h-point: c= 934507767 sw= 934794058 se= 934691555 nw= 934814696 ne= 934712693 Post-mixedlayer_restrat h
h-point: c= 934506835 sw= 934793170 se= 934690694 nw= 934813703 ne= 934711727 Post-mixedlayer_restrat h

This is Bodner, reading Cr and timescale fields from a file.

@theresa-morrison
Copy link

Thanks for testing this Kate. I am going to set up some short tests with each flag.

@kshedstrom
Copy link
Author

Bodner not reading from a file still differs in the DEBUG output.

I've got guests now and won't be able to dig in until next week. I don't think the Bodner trouble is causing the sea ice trouble.

@theresa-morrison
Copy link

I wasn't able to use the files restrat_vars files because I didn't have read access. If you have a minute to change the permissions that would be great. Otherwise I will test the bug fixes without the restrat vars files.

@kshedstrom
Copy link
Author

OK, done.

@theresa-morrison
Copy link

thanks!

@theresa-morrison
Copy link

Hi Kate, I was able to get your experiment running with the Bodner files and the bug fixes. I am seeing the bad sea-ice coverage and velocities. I tried turning off the Bodner files (using the default constants) and some of the bug fixes, but neither helped.

I'm not sure what else you changed from your previous experiment, but maybe skip the bug fixes until you are sure those changes are working well?

@kshedstrom
Copy link
Author

Can you try the code without Bob’s parentheses?

@theresa-morrison
Copy link

I am not sure that the FMA paretntheses are something that can be turned on/off with a flag.

I took a more careful look at my experiments. The Bodner files do seem to be causing the issues - although there is still a lot of excess ice without the files which is what I was looking at.

Left is with the default restratification parameters, right is using the spatially varying files.
image

@kshedstrom
Copy link
Author

Yes, I see your point. I will try PR #711 on gaea to see if it cleans things up. Thanks for testing it!

@theresa-morrison
Copy link

Kate can we close this issue now that the fix has been merged into dev/gfdl?

@kshedstrom
Copy link
Author

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants