Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slab ocean Q-flux is read in from file, but not propagated to Sfcprop%qfluxadj #34

Closed
spencerkclark opened this issue Dec 13, 2023 · 0 comments · Fixed by #35
Closed

Comments

@spencerkclark
Copy link
Member

spencerkclark commented Dec 13, 2023

Describe the bug

Within sfcsub.F, infrastructure is in place to read in an ocean Q-flux from a file into a locally defined qflux variable in the clima subroutine:

!
! qflux for slab ocean model
!
if(fnqfluxc(1:8).ne.' ') then
kpd7=-1
call fixrdc(lugb,fnqfluxc,kpdqflux,kpd7,mon,slmask,
& qflux(1,nn),len,iret
&, imsk, jmsk, slmskh, gaus,blno, blto
&, outlat, outlon, me)
if (me .eq. 0) write(6,*) 'climatological ocean
& mixed layer depth read in.'
endif

However, data from this local qflux variable is not propagated to the output qfluxadj variable, and therefore the Q-flux assigned to Sfcprop%qfluxadj (for eventual use elsewhere in the model) is always zero.

To Reproduce

Run SHiELD with a prescribed Q-flux file, i.e. with a file specified for the namsfc.fnqfluxc namelist parameter. It is useful to define a diagnostic pointing to Sfcprop%qfluxadj to assess this (I have done this in a fork).

Expected behavior

qfluxadj should be populated in a similar manner to mldclm, i.e. interpolated between monthly means loaded in from a file:

if(fnmldc(1:8).ne.' ') then
do i=1,len
mldclm(i) = wei1m * mld(i,k1) + wei2m * mld(i,k2)
enddo
endif

I have implemented this in a fork, and it seems to address this issue. I will make a PR after a little more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant