Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scorecard colors ignore user selection #1177

Closed
mollybsmith-noaa opened this issue Apr 23, 2024 · 1 comment
Closed

Scorecard colors ignore user selection #1177

mollybsmith-noaa opened this issue Apr 23, 2024 · 1 comment
Assignees
@mollybsmith-noaa
Labels
bug A defect or problem client Improvements or additions to the client code MATScommon An issue affecting the MATScommon project scorecard anything that is being done to support the scorecard

Comments

@mollybsmith-noaa
Copy link
Collaborator

Our scorecards have options for users to change the default colors. However, even if you change them the scorecards still come up with the defaults.
@mollybsmith-noaa mollybsmith-noaa added bug A defect or problem client Improvements or additions to the client code MATScommon An issue affecting the MATScommon project scorecard anything that is being done to support the scorecard labels Apr 23, 2024
@mollybsmith-noaa mollybsmith-noaa self-assigned this Apr 23, 2024
@mollybsmith-noaa
Copy link
Collaborator Author

This has been fixed, these event handlers had never been added:

"change [name='major-truth-color-icon']"(event) { document.getElementById("major-truth-color-color").value = document.querySelector( '[name="major-truth-color-icon"]' ).style.color; },
"change [name='minor-truth-color-icon']"(event) { document.getElementById("minor-truth-color-color").value = document.querySelector( '[name="minor-truth-color-icon"]' ).style.color; },
"change [name='major-source-color-icon']"(event) { document.getElementById("major-source-color-color").value = document.querySelector( '[name="major-source-color-icon"]' ).style.color; },
"change [name='minor-source-color-icon']"(event) { document.getElementById("minor-source-color-color").value = document.querySelector( '[name="minor-source-color-icon"]' ).style.color; },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mollybsmith-noaa mollybsmith-noaa

Labels
bug A defect or problem client Improvements or additions to the client code MATScommon An issue affecting the MATScommon project scorecard anything that is being done to support the scorecard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mollybsmith-noaa