Update ncm to ncm2 #15

FatBoyXPC · 2019-07-20T02:10:23Z

Note: this will break for anybody that currently uses ncm. I wasn't sure the right way to handle this - add a whole new group of stuff for ncm2, or just update it. I figured I would update it first since that was the easier path.

I tried to run the tests but bundle install failed, stating: Could not locate Gemfile

In order to get the routes completion working for ncm2, I had to make
the capture() function available from anywhere, and I needed to call it
with 2 arguments intead of 1.

In order to get the routes completion working for ncm2, I had to make the capture() function available from anywhere, and I needed to call it with 2 arguments intead of 1.

noahfrederick

Thanks for taking this on!

I wasn't sure the right way to handle this - add a whole new group of stuff for ncm2, or just update it.

Let's preserve the original ncm support, since the cost is low. But you can stick new autocommands in the same group (laravel_completion).

plugin/laravel.vim

noahfrederick · 2019-07-20T12:19:50Z

I tried to run the tests but bundle install failed, stating: Could not locate Gemfile

Not sure where this instruction came from, but there are none, unfortunately. :/

FatBoyXPC · 2019-07-20T19:35:16Z

That instruction came from CONTRIBUTING.md!

FatBoyXPC · 2019-07-21T00:07:40Z

Made the requesting changes, let me know if there's anything else!

noahfrederick

Looks good after these few formatting nitpicks.

I actually can't get it to work, but my autocompletion setup is perpetually broken in one way or another. As long as you've manually confirmed this works, I'm happy to merge it.

noahfrederick · 2019-07-21T00:43:32Z

plugin/laravel.vim

+        \ 'on_complete': 'laravel#completion#ncm2_routes',
+        \ })
+  autocmd User Ncm2Plugin call ncm2#register_source({
+        \ 'name' : 'Laravel View',


Suggested change

\ 'name' : 'Laravel View',

\ 'name': 'Laravel View',

noahfrederick · 2019-07-21T00:43:48Z

plugin/laravel.vim

+  " Set up ncm2 sources
+  " :help ncm2#register_source-example
+  autocmd User Ncm2Plugin call ncm2#register_source({
+        \ 'name' : 'Laravel Route',


Suggested change

\ 'name' : 'Laravel Route',

\ 'name': 'Laravel Route',

noahfrederick · 2019-07-21T00:44:27Z

plugin/laravel.vim

+        \ 'name' : 'Laravel Route',
+        \ 'priority': 9,
+        \ 'subscope_enable': 1,
+        \ 'scope': ['php','blade'],


Suggested change

\ 'scope': ['php','blade'],

\ 'scope': ['php', 'blade'],

noahfrederick · 2019-07-21T00:45:08Z

plugin/laravel.vim

+        \ 'name' : 'Laravel View',
+        \ 'priority': 9,
+        \ 'subscope_enable': 1,
+        \ 'scope': ['php','blade'],


Suggested change

\ 'scope': ['php','blade'],

\ 'scope': ['php', 'blade'],

Honestly I shouldn't have missed these to begin with :O

FatBoyXPC · 2019-07-21T01:11:28Z

It does work for me locally, but I wouldn't mind somebody else trying. Do you know anybody else using ncm2? How is your autocomplete currently broken? Maybe we could fix it and test my changes?

noahfrederick · 2019-07-21T01:42:49Z

Okay, I was able to create a working minimal configuration. Strangely, ncm2 is including view names (as well as the route names) in the route context and vice versa.

FatBoyXPC · 2019-07-21T01:44:48Z

That's strange, that doesn't happen for me. Can you share your minimal configuration so I can also try it?

noahfrederick · 2019-07-21T01:50:18Z

Replace paths to local copies of plug-ins as needed:

call plug#begin()
call plug#('roxma/nvim-yarp')
call plug#('ncm2/ncm2')

call plug#('~/src/vim-composer')
call plug#('~/src/vim-laravel')
call plug#end()

augroup init_ncm2
  autocmd!
  autocmd BufEnter * call ncm2#enable_for_buffer()
augroup END

set completeopt=menuone         " Display menu when completing, even for only one candidate
set completeopt+=noselect       " Do not automatically select first item
set completeopt+=noinsert       " Do not automatically insert first item

Starting Neovim 0.3.8 in a Laravel project with:

nvim -u path/to/minimal.vim app/Http/Controllers/Controller.php

noahfrederick · 2019-07-21T02:07:36Z

I've been reading through the documentation. I think the complete_pattern key doesn't scope the completions in the way the original ncm did, but rather just provides extra contexts for automatically popping up the menu. I think we may need to check the context ourselves before returning results for a particular completion type, which is a little bit of a drag.

FatBoyXPC · 2019-07-21T02:17:55Z

Hm, I do see this bug now, but only after I call route() a 2nd time. I'm attempting the minimal configuration right now, but I'm getting a lot of errors. Did you do a :PlugClean and :PlugInstall with that config before attempting this?

noahfrederick · 2019-07-21T02:27:31Z

Did you do a :PlugClean and :PlugInstall with that config before attempting this?

I did not, since it's a strict subset of my normal config. It shouldn't make a difference in my case.

but I'm getting a lot of errors.

Can you tell from what script?

FatBoyXPC · 2019-07-21T02:36:21Z

The only difference is that I commented out the vim-composer line because I don't use it (and it's not necessary for what I use this plugin for).

Here's a gif of what's happening:

FatBoyXPC · 2019-07-22T19:16:10Z

Hey, I found this in the docs:

    complete_length                 ncm2-complete_length                        
                        The minimum length of the matching word for auto        
                        triggering popup menu.                                  
                        If it contains a negative value, completion will only   
                        be triggered by complete_pattern.

This part being important:

If it contains a negative value, completion will only be triggered by complete_pattern.

Care to pull my changes and see if this is fixed?

noahfrederick

Works as expected now!

* Fix :Artisan make:model in Laravel 8. * Add support for artisan make:channel generator introduced in Laravel 5.6. * Dynamically complete Artisan flags. * Fold stack traces in log buffers. * Make gf go to intended config/translation file. * Implement completion via ncm2 (#15). * Always set up job/command nav commands. * Various bug fixes.

Update ncm to ncm2

5d27e93

In order to get the routes completion working for ncm2, I had to make the capture() function available from anywhere, and I needed to call it with 2 arguments intead of 1.

noahfrederick requested changes Jul 20, 2019

View reviewed changes

plugin/laravel.vim Outdated Show resolved Hide resolved

plugin/laravel.vim Outdated Show resolved Hide resolved

Add ncm support back per PR feedback

e501392

noahfrederick requested changes Jul 21, 2019

View reviewed changes

Formatting changes per PR feedback

112358e

Honestly I shouldn't have missed these to begin with :O

Only trigger via complete_pattern

602e4e1

noahfrederick approved these changes Jul 23, 2019

View reviewed changes

noahfrederick merged commit 2fdaf92 into noahfrederick:master Jul 23, 2019

noahfrederick mentioned this pull request Jul 23, 2019

Other completion managers #12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ncm to ncm2 #15

Update ncm to ncm2 #15

FatBoyXPC commented Jul 20, 2019 •

edited

Loading

noahfrederick left a comment

noahfrederick commented Jul 20, 2019

FatBoyXPC commented Jul 20, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick left a comment

noahfrederick Jul 21, 2019

noahfrederick Jul 21, 2019

noahfrederick Jul 21, 2019

noahfrederick Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick commented Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick commented Jul 21, 2019 •

edited

Loading

noahfrederick commented Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick commented Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

FatBoyXPC commented Jul 22, 2019

noahfrederick left a comment

Update ncm to ncm2 #15

Update ncm to ncm2 #15

Conversation

FatBoyXPC commented Jul 20, 2019 • edited Loading

noahfrederick left a comment

Choose a reason for hiding this comment

noahfrederick commented Jul 20, 2019

FatBoyXPC commented Jul 20, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick left a comment

Choose a reason for hiding this comment

noahfrederick Jul 21, 2019

Choose a reason for hiding this comment

noahfrederick Jul 21, 2019

Choose a reason for hiding this comment

noahfrederick Jul 21, 2019

Choose a reason for hiding this comment

noahfrederick Jul 21, 2019

Choose a reason for hiding this comment

FatBoyXPC commented Jul 21, 2019

noahfrederick commented Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick commented Jul 21, 2019 • edited Loading

noahfrederick commented Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

noahfrederick commented Jul 21, 2019

FatBoyXPC commented Jul 21, 2019

FatBoyXPC commented Jul 22, 2019

noahfrederick left a comment

Choose a reason for hiding this comment

FatBoyXPC commented Jul 20, 2019 •

edited

Loading

noahfrederick commented Jul 21, 2019 •

edited

Loading