Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile Loader not showing the tiles in the proper place #48

Closed
david-alejo opened this issue Mar 13, 2019 · 9 comments
Closed

Tile Loader not showing the tiles in the proper place #48

david-alejo opened this issue Mar 13, 2019 · 9 comments

Comments

@david-alejo
Copy link

Dear all,

First of all, thank you for the development of this plugin that I've found very handy.

I upgraded to the latest version yesterday to make it work in 18.04. I have found that now the satellite images are no longer in the proper placed. Instead, they appear with a small shift to the South and East.

I attach an example with the representation of coordinates 41.38738993 N 2.183433017 E in google maps and with your plugin in rviz to help to understand the differences.

Has any other noticed it?
issue_rviz_satellite
Screenshot from 2019-03-13 17-44-04

@beetleskin
Copy link
Contributor

beetleskin commented Mar 19, 2019

Is your robot_frame equal to the frame_id in the NavSat message? What tile-server are you using? Is this also happening with other tile-servers? Did you check the frame-conversion setting?

Could you provide a minimum working example to reproduce, via a PR?

@david-alejo
Copy link
Author

Thank you for your kind response. I'm checking the frame_id and if I can't correct it, I will provide a MWE.

Regarding to the tile served, I checked Google Maps and OpenStreetMap.

@david-alejo
Copy link
Author

I created a PR related to this issue as a minimum working example. In it, you can see a marker and the axes in the reference frame map. They do not correspond with the location of /gps/fix when using google maps.

@beetleskin
Copy link
Contributor

beetleskin commented Mar 22, 2019

Well, the demo is currently not working properly, the display produces an error. In your PR, please add

<node pkg="tf2_ros" type="static_transform_publisher" name="static_tf_fake" args="0 0 0 0 0 0 map base_link" /> and set the robot_frame to base_link. And try again.

Can you confirm that this works? If so, this is a duplicate of #49.

@david-alejo
Copy link
Author

Interesting. By doing so the tiles are loaded OK.

However, it is not clear why this is necessary. I mean: the plugin was configured to have /map as robot frame, why is it necessary to use the base_link frame?

@beetleskin
Copy link
Contributor

beetleskin commented Mar 22, 2019

Its not necessary (you can also use the /map frame) - but some frames need to be defined. That's true for most Display plugins, and for RViz itself.

@david-alejo
Copy link
Author

Ok it makes sense, I'm closing the issue as it is somehow duplicated with yours.

Thank you for your kind responses. Best regards,

@beetleskin
Copy link
Contributor

@schra maybe this isn a pure duplicate - I think the plugin should complain if frames are missing, rather than rendering bullshit. What do you think?

@schra
Copy link
Collaborator

schra commented Apr 29, 2019

@schra maybe this isn a pure duplicate - I think the plugin should complain if frames are missing, rather than rendering bullshit. What do you think?

Good point. I created an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants