Typescript definitions missing - encodedQueryParams and activeMocks #1514
Comments
|
We do not maintain @types/nock I’m afraid. Please file an issue at https://github.com/DefinitelyTyped/DefinitelyTyped/issues |
|
FYI: |
|
Yea, it seems like it needs to be public for the recorder to work. If someone wants to open a PR to document it we could make it official. |
|
That's exactly how I found it... recorder outputted it as part and then I needed to remove it to make TS happy when adding back the code to my tests. (Although I'm really not sure it was needed or why it was added, but that's a completely different conversation.) |
mastermatt
added a commit
to mastermatt/nock
that referenced
this issue
May 2, 2019
Identified as missing here nock#1514 (comment). This seems option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
mastermatt
added a commit
to mastermatt/nock
that referenced
this issue
May 2, 2019
Identified as missing here nock#1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
gr2m
pushed a commit
that referenced
this issue
May 2, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
gr2m
pushed a commit
that referenced
this issue
Sep 4, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
gr2m
pushed a commit
that referenced
this issue
Sep 4, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
gr2m
pushed a commit
that referenced
this issue
Sep 5, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the expected behavior?
Typescript will know about these parameters.
What is the actual behavior?
They are missing from the Typescript files
Possible solution
Add them. :)
How to reproduce the issue
nock.activeMocks()is missing => addexport function activeMocks(): string[];to the nock namespace.nock( 'https://api.github.com' , {"encodedQueryParams":true})=> addencodedQueryParams: booleanto the Options interface.Runkit: Example link
n/a
Having problem producing a test case? Try and ask the community for help. If the test case cannot be reproduced, the Nock community might not be able to help you.
n/a
Does the bug have a test case?
n/a
Versions
The text was updated successfully, but these errors were encountered: