-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Add encodedQueryParams option to docs. #1537
Merged
gr2m
merged 1 commit into
nock:beta
from
mastermatt:docs/add-encoded-query-params-option
May 2, 2019
Merged
chore(docs): Add encodedQueryParams option to docs. #1537
gr2m
merged 1 commit into
nock:beta
from
mastermatt:docs/add-encoded-query-params-option
May 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
approved these changes
May 2, 2019
Identified as missing here nock#1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
mastermatt
force-pushed
the
docs/add-encoded-query-params-option
branch
from
May 2, 2019 17:54
677d6cf
to
d7ceb63
Compare
I forgot to run the linter. Just pushed revision. |
Thanks a lot Matt! |
Thanks Matt! |
🎉 This PR is included in version 11.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
Identified as missing here #1514 (comment). This option seems to have been added to better support how the recorder saves and plays back. But as it is a valid, public option it should be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified as missing here #1514 (comment).
This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.
Tests already exist.