Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add encodedQueryParams option to docs. #1537

Merged
merged 1 commit into from
May 2, 2019

Conversation

mastermatt
Copy link
Member

Identified as missing here #1514 (comment).

This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.

Tests already exist.

Identified as missing here nock#1514 (comment).

This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.
@mastermatt mastermatt force-pushed the docs/add-encoded-query-params-option branch from 677d6cf to d7ceb63 Compare May 2, 2019 17:54
@mastermatt
Copy link
Member Author

I forgot to run the linter. Just pushed revision.

@gr2m
Copy link
Member

gr2m commented May 2, 2019

Thanks a lot Matt!

@gr2m gr2m merged commit 86c5c4f into nock:beta May 2, 2019
@mastermatt mastermatt deleted the docs/add-encoded-query-params-option branch May 2, 2019 17:59
@paulmelnikow
Copy link
Member

Thanks Matt!

@nockbot
Copy link
Collaborator

nockbot commented May 7, 2019

🎉 This PR is included in version 11.0.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nockbot
Copy link
Collaborator

nockbot commented Aug 12, 2019

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

gr2m pushed a commit that referenced this pull request Sep 4, 2019
Identified as missing here #1514 (comment).

This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.
gr2m pushed a commit that referenced this pull request Sep 4, 2019
Identified as missing here #1514 (comment).

This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.
gr2m pushed a commit that referenced this pull request Sep 5, 2019
Identified as missing here #1514 (comment).

This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants