test(Scope): Add unit test coverage for Scope.remove() #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear whether `remove()` is intended to be part of the public API. There did not seem to be a way to easily exercise this through the main `nock` API so this was approached as a unit test.
gr2m
approved these changes
Jan 6, 2019
gr2m
reviewed
Jan 6, 2019
| @@ -0,0 +1,85 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
I don’t think we need the use strict if we require Node 8+?
There was a problem hiding this comment.
Huh, I always used it in CJS modules though not in ES6 modules. That could be an obsolete practice, though. Not sure!
I found this which doesn't seem conclusive, but suggests it's still doing something: http://imaginativethinking.ca/what-the-heck-is-node-modules-strict-by-default/
|
🎉 This PR is included in version 11.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear whether
remove()is intended to be part of the public API. There did not seem to be a way to easily exercise this through the mainnockAPI so this was approached as a unit test.