refactor(restoreOverriddenRequests): Eliminate uncovered line #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
commented
May 1, 2019
| @@ -55,7 +55,7 @@ const isUtf8Representable = function(buffer) { | |||
| } | |||
|
|
|||
| // Array where all information about all the overridden requests are held. | |||
| let requestOverride = [] | |||
| let requestOverrides = {} | |||
There was a problem hiding this comment.
wait, what? How did this ever work?
There was a problem hiding this comment.
In JavaScript any object can be used as a dictionary, and I guess _.keys() did the right thing…
gr2m
approved these changes
May 2, 2019
| @@ -55,7 +55,7 @@ const isUtf8Representable = function(buffer) { | |||
| } | |||
|
|
|||
| // Array where all information about all the overridden requests are held. | |||
| let requestOverride = [] | |||
| let requestOverrides = {} | |||
There was a problem hiding this comment.
wait, what? How did this ever work?
|
🎉 This PR is included in version 11.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.