Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address used for authentication should be case-insensitive #627

Closed
davidleston-sureify opened this issue Oct 8, 2021 · 9 comments
Closed
Assignees
Labels
👋 For : Community or Good First Issue Targeting community to contribute 🎃 For : Hacktoberfest Targeting to Hacktoberfest Event

Comments

@davidleston-sureify
Copy link

The email address field used for sign up / sign in / reset password is not marked at type="email". Since it's not marked as an email field browsers will sometimes automatically capitalize the first letter when typed (as opposed to auto-fill).

The email address used in sign up / sign in is treated as case sensitive.

These two things combined create friction for new users and less technical users. My ideal is that both these fields would be marked as type="email" and emails would be treated as case insensitive. If just one of the two are implemented it would improve user experience.

According to RFC 1035 the bit before the @ sign may be case sensitive and the part after the @ sign is not case sensitive. In practice, email addresses are considered case insensitive. For example, Gmail (one of the largest email providers) treats email addresses as case insensitive.

please provide the following details :
(details not provided are unknown, I don't see the option to copy project info as shown in the YouTube video)
NocoDB version : 0.11.39
Database used in NC_DB URL : pg

Steps To Reproduce

  1. Using Safari on MacOS open a private window (browsers learn what fields are email addresses, opening a private window creates a window in which it has not yet learned that the field is an email address and will therefore capitalize the first letter)
  2. navigate to sign in, sign up, or forgot password
  3. start typing an email address with a period in it such as first.last@gmail.com
  4. Safari will capitalize the first letter once the period is typed.

Expected behavior
Email addresses should not be automatically capitalized.

@o1lab o1lab added 👋 For : Community or Good First Issue Targeting community to contribute 🎃 For : Hacktoberfest Targeting to Hacktoberfest Event labels Oct 8, 2021
@roman-rezinkin
Copy link
Contributor

Hi there, I would like to take a crack at this, could I be assigned?

@o1lab
Copy link
Member

o1lab commented Oct 8, 2021

Thank you - has been assigned.

Please see our contributing guide how to send git commit with signature - its simple.

@roman-rezinkin
Copy link
Contributor

Will do! Thank you @o1lab

@roman-rezinkin
Copy link
Contributor

@o1lab I am having an issue with permissions to push my code branch into a PR.
I am greeted with:

$ git push origin issue-627
remote: Permission to nocodb/nocodb.git denied to roman-rezinkin.
fatal: unable to access 'https://github.com/nocodb/nocodb/': The requested URL returned error: 403

I have followed the steps in the HowToApplyLicense.md file. If you could point me in the right direction, that would be amazing.

@wingkwong
Copy link
Member

@roman-rezinkin You are pushing the changes directly to nocodb/nocodb.git which you don't have permissions. You should fork the repository to your account and make changes there, then create a PR from your forked repository.

@roman-rezinkin
Copy link
Contributor

I have created a PR #632, if I could get a review on that, as well as I have left a comment in that PR #632 (comment), that I would like feedback on as well.

Thank you 👍

@pranavxc pranavxc reopened this Oct 12, 2021
pranavxc added a commit that referenced this issue Oct 12, 2021
re #627

Signed-off-by: Pranav C <pranavxc@gmail.com>
@khushbooag4
Copy link

I want to work on this. If it still open

@o1lab
Copy link
Member

o1lab commented Oct 21, 2021

This is fixed here.

Please see other issues marked as community.

@pranavxc
Copy link
Member

Fixed in v0.80.0

akbarpasha pushed a commit to akbarpasha/nocodb that referenced this issue Nov 15, 2021
re nocodb#627

Signed-off-by: Pranav C <pranavxc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 For : Community or Good First Issue Targeting community to contribute 🎃 For : Hacktoberfest Targeting to Hacktoberfest Event
Projects
None yet
Development

No branches or pull requests

6 participants