-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email address used for authentication should be case-insensitive #627
Comments
Hi there, I would like to take a crack at this, could I be assigned? |
Thank you - has been assigned. Please see our contributing guide how to send git commit with signature - its simple. |
Will do! Thank you @o1lab |
@o1lab I am having an issue with permissions to push my code branch into a PR.
I have followed the steps in the HowToApplyLicense.md file. If you could point me in the right direction, that would be amazing. |
@roman-rezinkin You are pushing the changes directly to nocodb/nocodb.git which you don't have permissions. You should fork the repository to your account and make changes there, then create a PR from your forked repository. |
I have created a PR #632, if I could get a review on that, as well as I have left a comment in that PR #632 (comment), that I would like feedback on as well. Thank you 👍 |
re #627 Signed-off-by: Pranav C <pranavxc@gmail.com>
I want to work on this. If it still open |
This is fixed here. Please see other issues marked as community. |
Fixed in |
re nocodb#627 Signed-off-by: Pranav C <pranavxc@gmail.com>
The email address field used for sign up / sign in / reset password is not marked at type="email". Since it's not marked as an email field browsers will sometimes automatically capitalize the first letter when typed (as opposed to auto-fill).
The email address used in sign up / sign in is treated as case sensitive.
These two things combined create friction for new users and less technical users. My ideal is that both these fields would be marked as type="email" and emails would be treated as case insensitive. If just one of the two are implemented it would improve user experience.
According to RFC 1035 the bit before the @ sign may be case sensitive and the part after the @ sign is not case sensitive. In practice, email addresses are considered case insensitive. For example, Gmail (one of the largest email providers) treats email addresses as case insensitive.
please provide the following details :
(details not provided are unknown, I don't see the option to copy project info as shown in the YouTube video)
NocoDB version : 0.11.39
Database used in NC_DB URL : pg
Steps To Reproduce
Expected behavior
Email addresses should not be automatically capitalized.
The text was updated successfully, but these errors were encountered: