This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Fix imported sass not updating #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also renamed root_destination to be in_place_destination to better reflect its purpose
This method is already using site.static_files doesn't seem necessary to conditionally check the class.
…l practice. Also implemented accessor methods directly.
Config that defaults to expanded when watching (for debugging css), compressed when building.
It's probably best to let other errors crash jekyll. A write issue is an indicator of deeper problems. Syntax can be corrected while jekyll is still running.
Because there is often pretty deep linking in sass, rebuilding only one changed sass file doesn't update dependent files. Also, files with underscores are ignored by jekyll, its important for sass to rebuild when these files are modified.
Using the for_file initializer for the sass engine, it auto detects the syntax via the file name. Updated docs as well.
noct
added a commit
that referenced
this pull request
Oct 7, 2013
Dependent update fix, deploy_style, and syntax detection
|
Sorry I took so long to get to this, great stuff @rebelzach! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few additions to help with --watch mode. This PR updates the generator to keep track of sass files that also start with underscores, if any sass files are modified it triggers a full sass update. This corrects an issue where file
a.sassimports file_b.sassupdating file_b.sassdoes not causea.sassto re-render.Other updates
_sitedirectoryAnyway, I've found these changes to be helpful with my current jekyll setup. Let me know your thoughts.