feat: allow multiple connections #33
Conversation
This PR allows `casbin-mongoose-adapter` to instantiate multiple connections to different connections strings. It makes it easier to test code that depends on this adapter and give more flexibility to where casbin policies will be stored.
| it('Should properly instantiate multiple adapters', async () => { | ||
| const adapter1 = new MongooseAdapter('mongodb://localhost:27001/casbin', { ...MONGOOSE_OPTIONS, autoCreate: true }); | ||
| const adapter2 = new MongooseAdapter('mongodb://localhost:27001/casbin2', { ...MONGOOSE_OPTIONS, autoCreate: true }); | ||
|
|
||
| assert.instanceOf(adapter1, MongooseAdapter); | ||
| assert.isFalse(adapter1.isFiltered()); | ||
|
|
||
| assert.instanceOf(adapter2, MongooseAdapter); | ||
| assert.isFalse(adapter2.isFiltered()); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I tried to add a test here, but I noticed some others were failing, so not sure if I did this the right way.
If you can direct me, I'd be happy to implement proper tests.
|
@fdionisi plz fix:
|
|
@hsluoyz I'll do my best here. When I pull the master branch and run It looks something is off with the integration tests (note I added myself a unit test here). |
|
@fdionisi Seems it's not a good idea. |
|
If you truly want to use such an implement, |
|
Oh, now I see what is happening here. The tests are actually getting the transpiled JavaScript code (from |
@Zxilly Uhm, not sure what you are referring to, but let me dig a bit deeper in the code, and I'll try to get back here with a solution. |
|
@fdionisi Please read the link I provided above. |
|
Can somebody explain the use case? The flexibility part especially does not seem very practical or useful to me at least. |
Connecting to one MongoDB URL for resources and connect to a different one for casbin rules. It also shows up running tests in parallel - for some of them, I need a brand new database. If you believe it doesn't add value, then fair enough - possibly it is useful only to me. |
|
For initial setup and testing that might be useful temporarily. However I would personally use fixtures, backups or scripts so that you are easily able to reset your testing database to desired state. Multiple database connection can cause more issues than it tries to solve and in the end I would assume that you want to use singular database for all queries. Especially when we talk about production environments with clusters and replicas involved. |
|
@Sefriol, I get it. The tests are passing correctly. The decision is up to you guys; if you think this brings nothing to the table or the implementation is not to your liking, I understand. Let me know, and I'll close the PR. |
|
Sorry that I will close this PR based on above discussions. |
This PR allows
casbin-mongoose-adapterto instantiate multipleconnections to different connections strings. It makes it easier to test
code that depends on this adapter and give more flexibility to where casbin
policies will be stored.