Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for custom table name #50

Merged
merged 2 commits into from
Jul 16, 2021
Merged

feat: add support for custom table name #50

merged 2 commits into from
Jul 16, 2021

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Jul 15, 2021 •
edited by hsluoyz
Loading

Fix: #43

@Gabriel-403 @hsluoyz @nodece plz review
Signed-off-by: Zxilly zhouxinyu1001@gmail.com

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1033401119

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 86.111%
Totals Coverage Status
Change from base Build 716249754: -0.1%
Covered Lines: 99
Relevant Lines: 107
💛 - Coveralls

@hsluoyz
Copy link
Member

hsluoyz commented Jul 15, 2021

@Zxilly plz finish: #47 first

@Gabriel-403
Copy link
Contributor

Gabriel-403 commented Jul 15, 2021 •
edited by hsluoyz
Loading

@Zxilly plz finish: #47 first

I am woking on this,this is my task

nodece
nodece approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsluoyz
Copy link
Member

hsluoyz commented Jul 16, 2021

@Zxilly plz fix:

image

@Zxilly
feat: add support for custom table name
5f587ab 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
style: make eslint happy :(
e79f7ea 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
Copy link
Contributor Author

Zxilly commented Jul 16, 2021

@hsluoyz resolved

@hsluoyz hsluoyz merged commit 3a0fdfc into node-casbin:master Jul 16, 2021
@hsluoyz hsluoyz mentioned this pull request Jul 16, 2021
Closed
@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom table name
5 participants
@Zxilly @coveralls @hsluoyz @Gabriel-403 @nodece