Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix :Switch from travis-ci.org to GitHub Actions CI and setup semantic-rel… #52

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Fix :Switch from travis-ci.org to GitHub Actions CI and setup semantic-rel… #52

merged 1 commit into from
Jul 16, 2021

Conversation

Gabriel-403
Copy link
Contributor

fix : #47

@Gabriel-403 Gabriel-403 force-pushed the fix_47 branch 3 times, most recently from fc7c193 to e7ed4a4 Compare July 16, 2021 06:41
@Gabriel-403
Switch from travis-ci.org to GitHub Actions CI and setup semantic-rel…
cbeb097 
…ease

Signed-off-by: Gabriel-403 <1499015923@qq.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1037414933

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.232%
Totals Coverage Status
Change from base Build 716249754: 0.0%
Covered Lines: 94
Relevant Lines: 102
💛 - Coveralls

hsluoyz
hsluoyz requested changes Jul 16, 2021
View reviewed changes
package.json Show resolved Hide resolved
zhmushan
zhmushan approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@zhmushan zhmushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Moving casbin to peer deps has nothing to do with this topic, but I think the right user should have installed both libraries at the same time

Zxilly
Zxilly approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@Zxilly Zxilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsluoyz hsluoyz merged commit c3e0b79 into node-casbin:master Jul 16, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Jul 16, 2021 •
edited
Loading

@Gabriel-403 still failing:

https://github.com/node-casbin/sequelize-adapter/runs/3087250561?check_suite_focus=true

image

@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsluoyz hsluoyz hsluoyz approved these changes

@zhmushan zhmushan zhmushan approved these changes

@Zxilly Zxilly Zxilly approved these changes

@nodece nodece Awaiting requested review from nodece

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from travis-ci.org to GitHub Actions CI and setup semantic-release
5 participants
@Gabriel-403 @coveralls @hsluoyz @zhmushan @Zxilly