Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of #1449 #1453

Merged
merged 2 commits into from Jan 16, 2022
Merged

backport of #1449 #1453

merged 2 commits into from Jan 16, 2022

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Jan 15, 2022

Purpose

backport of #1449 as a bug/security fix

@jimmywarting jimmywarting requested review from gr2m and bitinn Jan 15, 2022
@jimmywarting jimmywarting requested a review from LinusU Jan 15, 2022
tekwiz
tekwiz approved these changes Jan 15, 2022
@jimmywarting jimmywarting merged commit 1ef4b56 into node-fetch:2.x Jan 16, 2022
@jimmywarting jimmywarting deleted the header-fix branch Jan 16, 2022
@tronza
Copy link

@tronza tronza commented Jan 18, 2022

@jimmywarting Not sure if it's on your turf, but Snyk still shows v2.6.7 as vulnerable. https://snyk.io/test/npm/node-fetch/2.6.7?tab=issues

@tronza
Copy link

@tronza tronza commented Jan 19, 2022

@jimmywarting Not sure if it's on your turf, but Snyk still shows v2.6.7 as vulnerable. https://snyk.io/test/npm/node-fetch/2.6.7?tab=issues

They changed it now. Disregard 😄

@jimmywarting
Copy link
Collaborator Author

@jimmywarting jimmywarting commented Jan 19, 2022

grate, i was going to lookin to comfirm with it yesterday but got tied up with other work and it was getting late. glad they changed it.

@Bonnefin
Copy link

@Bonnefin Bonnefin commented Jan 20, 2022

@jimmywarting FYI GitHub Advisory Database is still showing any version <3.1.1 as vulnerable including this backport so npm audit is flagging it. GHSA-r683-j2x4-v87g Is there anything that can be done from your end about this?

@jimmywarting
Copy link
Collaborator Author

@jimmywarting jimmywarting commented Jan 20, 2022

not sure what to do actually... it's fixed already.

@Trott
Copy link

@Trott Trott commented Jan 22, 2022

not sure what to do actually... it's fixed already.

I ran into the same issue with a package I maintain not that long ago. I had to ping GitHub/npm staff to fix it. (They apparently have a feature in the works to allow folks to suggest updates but it's not rolled out yet.)

@Trott
Copy link

@Trott Trott commented Jan 22, 2022

not sure what to do actually... it's fixed already.

I ran into the same issue with a package I maintain not that long ago. I had to ping GitHub/npm staff to fix it. (They apparently have a feature in the works to allow folks to suggest updates but it's not rolled out yet.)

https://twitter.com/trott/status/1484902304931205125

@Trott
Copy link

@Trott Trott commented Jan 22, 2022

@jimmywarting You'll also want to update https://nvd.nist.gov/vuln/detail/CVE-2022-0235. For that, email nvd@nist.gov.

@Pyrolistical
Copy link

@Pyrolistical Pyrolistical commented Jan 26, 2022

Looks like https://nvd.nist.gov/vuln/detail/CVE-2022-0235 was updated to include 2.6.7!

otc-zuul bot pushed a commit to opentelekomcloud/ui-cluster-driver-otc that referenced this issue Mar 29, 2022
Bump node-fetch from 2.6.1 to 2.6.7

Bumps node-fetch from 2.6.1 to 2.6.7.

Release notes
Sourced from node-fetch's releases.

v2.6.7
Security patch release
Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred
What's Changed

fix: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1453

Full Changelog: node-fetch/node-fetch@v2.6.6...v2.6.7
v2.6.6
What's Changed

fix(URL): prefer built in URL version when available and fallback to whatwg by @​jimmywarting in node-fetch/node-fetch#1352

Full Changelog: node-fetch/node-fetch@v2.6.5...v2.6.6
v2.6.2
fixed main path in package.json



Commits

1ef4b56 backport of #1449 (#1453)
8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310)
f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (...
b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303)
18193c5 fix v2.6.3 that did not sending query params (#1301)
ace7536 fix: properly encode url with unicode characters (#1291)
152214c Fix(package.json): Corrected main file path in package.json (#1274)
See full diff in compare view



Maintainer changes
This version was pushed to npm by endless, a new releaser for node-fetch since your current version.



Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Reviewed-by: Anton Kachurin <katchuring@gmail.com>
otc-zuul bot pushed a commit to opentelekomcloud/ui-driver-otc that referenced this issue Apr 12, 2022
Bump node-fetch from 2.6.1 to 2.6.7

Bumps node-fetch from 2.6.1 to 2.6.7.

Release notes
Sourced from node-fetch's releases.

v2.6.7
Security patch release
Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred
What's Changed

fix: don't forward secure headers to 3th party by @​jimmywarting in node-fetch/node-fetch#1453

Full Changelog: node-fetch/node-fetch@v2.6.6...v2.6.7
v2.6.6
What's Changed

fix(URL): prefer built in URL version when available and fallback to whatwg by @​jimmywarting in node-fetch/node-fetch#1352

Full Changelog: node-fetch/node-fetch@v2.6.5...v2.6.6
v2.6.2
fixed main path in package.json



Commits

1ef4b56 backport of #1449 (#1453)
8fe5c4e 2.x: Specify encoding as an optional peer dependency in package.json (#1310)
f56b0c6 fix(URL): prefer built in URL version when available and fallback to whatwg (...
b5417ae fix: import whatwg-url in a way compatible with ESM Node (#1303)
18193c5 fix v2.6.3 that did not sending query params (#1301)
ace7536 fix: properly encode url with unicode characters (#1291)
152214c Fix(package.json): Corrected main file path in package.json (#1274)
See full diff in compare view



Maintainer changes
This version was pushed to npm by endless, a new releaser for node-fetch since your current version.



Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Reviewed-by: Anton Kachurin <katchuring@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants