fix: vendor hexoid until v2 is released #978
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The v1.0.0 release of hexoid is incompatible with webpack.
main.js
webpack.config.js
Output:
Root Cause:
Webpack prefers the
module
entry over themain
entry inpackage.json
by default, buthexoid
exports incompatible APIs between the commonjs & esm modules. The esm module uses adefault
export which is not equivalent to themodule.exports
assignment in the commonjs module.Solution 1:
The hexoid repo has fixed the inconsistency in their
master
branch, but haven't published a release in 4 years. I've requested a v2 be published with the new exports. Once this happens, we can upgrade to that: lukeed/hexoid#7Solution 2:
In the meantime, I propose that we vendor the
hexoid
code as a helper function.