Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave rawHeaders case untouched on nock's replies #710

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Leave rawHeaders case untouched on nock's replies #710

merged 1 commit into from
Oct 7, 2016

Conversation

hugoduraes
Copy link
Contributor

Pull request for issue #707

@coveralls
Copy link

coveralls commented Oct 3, 2016

Coverage Status

Coverage decreased (-0.08%) to 96.48% when pulling d496aa0 on hugoduraes:master into ea64fe3 on node-nock:master.

Copy link
Contributor

@vrinek vrinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave the PR a read and it looks good.

It seems that it has broken tests for node v0.10 (see https://travis-ci.org/node-nock/nock/builds/164659061 Vs https://travis-ci.org/node-nock/nock). If it's easy to fix, please give it a go. On that note, there is an open question on whether it's worth the effort to support pre-LTS node versions (current LTS is v4).

@coveralls
Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage decreased (-0.01%) to 96.547% when pulling 24bb077 on hugoduraes:master into ea64fe3 on node-nock:master.

@hugoduraes
Copy link
Contributor Author

Fixed on Node 0.10.x. It happens that Node 0.10.x HTTP module does not send the response rawHeaders. So it nows falls back to headers whenever rawHeaders is not available.

@vrinek vrinek merged commit 5b49553 into nock:master Oct 7, 2016
@vrinek
Copy link
Contributor

vrinek commented Oct 7, 2016

Thanks!

@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants