Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip browserify test because zombie fails @7.10 #942

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

michaelnisi
Copy link
Contributor

Skipping the browserify test for Node versions >7.9 to remedy #933, assuming this might be a Zombie issue, which is out of scope for me to fix.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.686% when pulling f6581bf on michaelnisi:browserify into 17d7c25 on node-nock:master.

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage remained the same at 92.686% when pulling 0e0b4bb on michaelnisi:browserify into 17d7c25 on node-nock:master.

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage remained the same at 92.686% when pulling 3eaded9 on michaelnisi:browserify into 17d7c25 on node-nock:master.

@michaelnisi
Copy link
Contributor Author

michaelnisi commented Jul 5, 2017

Unfortunately, Travis CI build is still broken for 6 and 8, for unrelated reasons, producing erratic results, though; correlating with #936. But at least this PR resolves #933.

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage remained the same at 92.686% when pulling 908eb9f on michaelnisi:browserify into 17d7c25 on node-nock:master.

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage remained the same at 92.686% when pulling cac446d on michaelnisi:browserify into 17d7c25 on node-nock:master.

@coveralls
Copy link

coveralls commented Jul 5, 2017

Coverage Status

Coverage remained the same at 92.686% when pulling 0c0aaca on michaelnisi:browserify into 17d7c25 on node-nock:master.

@ianwsperber
Copy link
Contributor

Accepting this as another patch on the leaky ship of nock

@ianwsperber ianwsperber merged commit 39c7e32 into nock:master Jul 11, 2017
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants