respect user-provided multiple regexes for allowUnmocked and match #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
requested changes
Sep 19, 2017
There was a problem hiding this comment.
Can you please remove the package-lock.json and the other package.json changes? I’ve run into this myself but want to address it in a separate PR
Could you add the test case from #835 in a separate commit and then your fix in another. That makes it easier for us to review, as we see that the test actually failed and that your changes fixed it. Please add (#835) to the test title
test('match path using regexp with allowUnmocked (#835)', function (t) {
...
|
Will do asap |
|
done via #973 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835
This was an issue for me as I'm hardly using hardcoded strings due to dynamic hosts and urls, so regex matching is preferable.
Happy to write regression tests for this if it is expected behavior. (Looking at the docs, myself and others seem to think this should work out of the box)