Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove console.log from library #13

Closed
yahasa opened this issue Apr 26, 2018 · 3 comments
Closed

Please remove console.log from library #13

yahasa opened this issue Apr 26, 2018 · 3 comments

Comments

@yahasa
Copy link

yahasa commented Apr 26, 2018

Please remove console.log from Client.js. In some cases it's an unexpected behaviour.

@nodegin
Copy link
Owner

nodegin commented May 1, 2018

Hi, sorry for delay. Can you explain what mean unexpected behavior?

@yahasa
Copy link
Author

yahasa commented May 1, 2018

Hi, sorry I didn't explain the problem.
If I use external logging library all my logs controlled by logger. If some library use console it pollutes the screen.
For example, then I use terminal UI (https://github.com/chjj/blessed on screenshot) it looks like:

uncontrolled_log_example

In your library just one direct console usage, and I think it's not so informative.
console.log('Current update is empty.')

Also it would be perfect to control getInput from outside the library (and get rid of inquirer dependency ~ 10Mb in node_modules), but it's another issue.

@nodegin
Copy link
Owner

nodegin commented May 2, 2018

Hello, the Current update is empty. log is removed in the next release. For the getInput method do you have any nice idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants