Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packed app won't run if there's a space in the file path #29

Closed
krage opened this issue Jan 13, 2020 · 3 comments
Closed

Packed app won't run if there's a space in the file path #29

krage opened this issue Jan 13, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@krage
Copy link

krage commented Jan 13, 2020

Using version 1.1.2. Easy to reproduce on Windows, haven't checked if this is an issue elsewhere.

Starting in c:/temp:

git clone https://github.com/nodegui/nodegui-starter
cd nodegui-starter
npm install
npm install --save-dev @nodegui/packer
npm run-script build
npx nodegui-packer --init MyApp
npx nodegui-packer --pack dist
cd deploy/win32/build/MyApp
./qode

Above all works fine and hello world app appears. Now to introduce a space in the path:

cd ..
mv MyApp "MyApp with spaces"
cd "MyApp with spaces"
./qode

Errors out in console before managing to load:

internal/modules/cjs/loader.js:628
    throw err;
    ^

Error: Cannot find module 'C:/temp/nodegui-starter/deploy/win32/build/MyApp'
Require stack:
- internal/preload
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:625:15)
    at Function.Module._load (internal/modules/cjs/loader.js:527:27)
    at Module.require (internal/modules/cjs/loader.js:683:19)
    at Module._preloadModules (internal/modules/cjs/loader.js:939:12)
    at loadPreloadModules (internal/bootstrap/pre_execution.js:392:5)
    at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:53:3)
    at internal/main/repl.js:18:1 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ 'internal/preload' ]

Seems specific to packer since renaming parent to c:/temp/nodegui starter and running npx qode ./dist/index.js from there works fine.

@constgen
Copy link

constgen commented Feb 9, 2020

I can confirm this issue. Can stably reproduce it with spaces in folder names in Windows OS

@a7ul a7ul added the bug Something isn't working label Feb 9, 2020
@a7ul
Copy link
Collaborator

a7ul commented Feb 9, 2020

Thanks for reporting @krage and @constgen . Will take a look on this when I clear up some more backlog. Any help appreciated.

@a7ul
Copy link
Collaborator

a7ul commented Mar 7, 2020

This should be fixed in the latest version of nodegui and qode.

Please reopen if it doesnt work for you.

@a7ul a7ul closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants