Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating Richard Lau #1096

Closed
Trott opened this issue Oct 11, 2021 · 25 comments
Closed

Nominating Richard Lau #1096

Trott opened this issue Oct 11, 2021 · 25 comments

Comments

@Trott
Copy link
Member

Trott commented Oct 11, 2021

Per the Charter:

Changes to TSC membership should be posted in the agenda, and may be suggested as any other agenda item.

I'd like to nominate Richard Lau. He has been a longstanding invaluable contributor. Excellent code reviews. Top-notch communicator. Irreplaceable resource for Build WG and Releasers. Great code contributions too, of course. Long overdue, in my opinion.

@nodejs/tsc

@nschonni
Copy link
Member

Not sure if this will be over number max number of seats for IBM #829 (comment). Just triggered the memory of the previous discussion

@Trott
Copy link
Member Author

Trott commented Oct 11, 2021

Not sure if this will be over number max number of seats for IBM #829 (comment). Just triggered the memory of the previous discussion

The charter indicates the maximum is one-fourth. With Richard added, we would have 22 members, so a single employer could have up to 5 members.

IBM/RedHat currently has 3 (Beth, Gireesh, Michael).

I believe they previously had 5 (the current members, plus Sam Roberts and Dan Bevenius) but that is no longer the case.

So we're all good there, I think.

@mmarchini
Copy link
Contributor

+1

8 similar comments
@BridgeAR
Copy link
Member

+1

@joyeecheung
Copy link
Member

+1

@apapirovski
Copy link
Member

+1

@gireeshpunathil
Copy link
Member

+1

@targos
Copy link
Member

targos commented Oct 11, 2021

+1

@mcollina
Copy link
Member

+1

@ronag
Copy link
Member

ronag commented Oct 11, 2021

+1

@aduh95
Copy link
Contributor

aduh95 commented Oct 11, 2021

+1

@cjihrig
Copy link
Contributor

cjihrig commented Oct 11, 2021

+1

2 similar comments
@BethGriggs
Copy link
Member

+1

@mhdawson
Copy link
Member

+1

@MylesBorins
Copy link
Member

Huge +1

@tniessen
Copy link
Member

+1

1 similar comment
@ChALkeR
Copy link
Member

ChALkeR commented Oct 14, 2021

+1

@mhdawson
Copy link
Member

@Trott I think I see 16 +1s. I think this issue constitutes the required vote so we could consider this concluded by Monday so that Richard can be a member by the next meeting. Make sense?

@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

Obviously, I'm +1, but leaving this here to make it official.

@mhdawson
Copy link
Member

Sounds like we are in agreement that we can formally confirm in the next TSC meeting. @richardlau welcome to the TSC :)

@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

I've copied the TSC onboarding checklist at https://github.com/nodejs/TSC/blob/main/ONBOARDING.md#onboarding below. Let's leave this open until these are all done:

@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

  • Add the new member to the @nodejs/tsc and @nodejs/security-tsc teams.

Aside: We should get rid of security-tsc and use tsc for both purposes.

@targos
Copy link
Member

targos commented Oct 19, 2021

We should get rid of security-tsc and use tsc for both purposes.

security-tsc exists to be a child team of security

@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

We should get rid of security-tsc and use tsc for both purposes.

security-tsc exists to be a child team of security

Oh, right, I had thought of that but then figured tsc could be a child team of security but...that makes no sense. Never mind (unless someone has a good solution). I guess the real thing to do here is find a way to automate they synchronizing of security-tsc with tsc but that's probably more work than it's worth.

@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

I guess the real thing to do here is find a way to automate they synchronizing of security-tsc with tsc but that's probably more work than it's worth.

I suppose an easy win could be a weekly Action job that compares the two teams and opens an issue if they're different. It could also (if given the correct permissions) compare against teams in nodejs-private that are supposed to be synchronized with teams in nodejs.

nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Oct 19, 2021
Refs: nodejs/TSC#1096

PR-URL: #40523
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau added a commit to nodejs/email that referenced this issue Oct 20, 2021
richardlau added a commit to nodejs/create-node-meeting-artifacts that referenced this issue Oct 20, 2021
richardlau added a commit to nodejs/email that referenced this issue Oct 20, 2021
mhdawson pushed a commit to nodejs/create-node-meeting-artifacts that referenced this issue Oct 20, 2021
@Trott Trott closed this as completed Oct 21, 2021
targos pushed a commit to nodejs/node that referenced this issue Oct 23, 2021
Refs: nodejs/TSC#1096

PR-URL: #40523
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit to nodejs/node that referenced this issue Nov 23, 2021
Refs: nodejs/TSC#1096

PR-URL: #40523
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests