-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requesting TSC consensus to override Collaborator objection in https://github.com/nodejs/node/pull/32324 #840
Comments
+1 |
2 similar comments
+1 |
+1 |
+1 --- and I assume the +1 are "agree to landing despite the one objection" I guess the question is, does anybody in the TSC disagree about landing? If so, then we might need to discuss further in the PR. |
I'm +1 on getting the revert PR landed but also would like to see the ASAN checks worked through and enabled eventually. |
@jasnell see nodejs/node#32380, we should have ASAN checks in our CI in the future. I'm trying some alternative options to run ASAN on Actions, but since I don't know how long it will take until we figure out something viable for our CI, I'm still in favor of removing it from CI for now. |
+1 to landing nodejs/node#32324 and to fixing nodejs/node#32380. |
Looks like we've achieved consensus in the issue after all. Closing this. Thanks, everyone. |
Please see discussion in nodejs/node#32324. I believe that pull request should land. At the time of this writing, it has 6 Collaborator approvals, but also one Collaborator opposed to landing it.
I'm seeking TSC consensus to land it.
Thanks for reviewing this issue.
The text was updated successfully, but these errors were encountered: