Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a nodejs npm organization? #545

Closed
ronag opened this issue Aug 24, 2020 · 45 comments
Closed

Create a nodejs npm organization? #545

ronag opened this issue Aug 24, 2020 · 45 comments

Comments

@ronag
Copy link
Member

ronag commented Aug 24, 2020

I think it might make sense to have a NodeJS organization on npm where different working groups could publish packages, e.g. @nodejs/undici, @nodejs/quic etc... for feedback on new modules we are working on before or as an alternative to inclusion into core. I think this sometimes would be a preferable workflow to adding features as "experimental" (unless they depend on code in core).

Would also be potentially useful for future packages we are working on in @nodejs/web-server-frameworks through e.g. #531.

@mmarchini
Copy link
Contributor

cc @nodejs/tsc @nodejs/community-committee

I think having an npm org so we can publish scoped packages is a good idea.

https://www.npmjs.com/org/nodejs already exists. I don't know if it is owned by any of us or not though (it's not owned by the old nodejs-foundation user). If it's not owned, we need to send a request to npm to transfer ownership.

@bnb
Copy link
Contributor

bnb commented Aug 24, 2020

@mmarchini afaik it is us.

@mmarchini
Copy link
Contributor

I think so too, but I really can't tell with all that information on npm
image

@mhdawson
Copy link
Member

mhdawson commented Aug 24, 2020

When we last discussed we went with using the nodejs-foundation as described in one of the docs (don't have time to find it right now).

There have been discussion over the years that maybe we should use the org feature (at the start is was not as well established), but I was not in the loop if we created it.

@bnb
Copy link
Contributor

bnb commented Aug 25, 2020

Ah yeah, I remember that - I think the reason why we did this was to preserve the scope of @nodejs/ for core if we were to align with some web standards that were being discussed around scoped modules. @MylesBorins may have more context on that/how it's progressed?

@bnb
Copy link
Contributor

bnb commented Aug 25, 2020

As an extension of that: I don't think @nodejs-foundation/ makes sense anymore at all and we should reconsider that decision.

@mmarchini
Copy link
Contributor

Agreed, but I don't think nodejs-foundation is an npm org, seems like it's a regular user: https://www.npmjs.com/~nodejs-foundation

@richardlau
Copy link
Member

Agreed, but I don't think nodejs-foundation is an npm org, seems like it's a regular user: https://www.npmjs.com/~nodejs-foundation

Correct, it is a regular user owned by the Build WG:

It's meant to be there as a backup to prevent us being locked out of any modules we own, e.g. due to users becoming inactive.

@mhdawson
Copy link
Member

mhdawson commented Sep 2, 2020

On nodejs-foundation I think we talked about changing it but I think the agreement was that it was not worth the work required. If it had been an org that would have been different.

@mmarchini
Copy link
Contributor

We should transfer the @nodejs org ownership to nodejs-foundation, we just need to figure out who owns it now. Or we could send a request to npm 😅

@bnb
Copy link
Contributor

bnb commented Sep 3, 2020

@mmarchini in the i18n issue, it's noted that we own @nodejs/ and there's pushback on using it. ref: #505

@ronag
Copy link
Member Author

ronag commented Sep 3, 2020

and there's a lot of pushback on using it. ref: #505

I wouldn't say there is a lot of pushback. There are some questions and opinions on the matter and could be worth further discussing.

@mmarchini
Copy link
Contributor

mmarchini commented Sep 3, 2020

Either way, we should transfer the nodejs org on npm to the nodejs-foundation account, regardless of how we're going to use it

@bnb
Copy link
Contributor

bnb commented Sep 3, 2020

@ronag edited my phrasing 👍🏻

@tniessen
Copy link
Member

tniessen commented Sep 4, 2020

We should transfer the @nodejs org ownership to nodejs-foundation, we just need to figure out who owns it now. Or we could send a request to npm 😅

I think @ChALkeR owns @nodejs, but I am not quite sure.

@ChALkeR
Copy link
Member

ChALkeR commented Sep 4, 2020

@tniessen On npm? I don't.
I recommend contacting npm, Inc. support for that, I think?

Also, +1 to the transfer idea.

@MylesBorins
Copy link
Contributor

I am not sure who exactly own it but I can dig in.

@mmarchini
Copy link
Contributor

I'll submit a transfer request to npm using the nodejs-foundation account, that's probably the fastest way to find out and get it transferred

@MylesBorins
Copy link
Contributor

I've already identified the owner and started the transfer request to my personal account (didn't think about transferring to foundation account)
can update it

@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 4, 2020

I'm an owner now! (also an owner of the @node scope)

there is a nodejs-admin account on both, is that something is managing?

So the next step is to add nodejs-foundation as an admin?

@mmarchini
Copy link
Contributor

I believe so, yeah

@MylesBorins
Copy link
Contributor

I've invited nodejs-foundation to both the @node and @nodejs scopes

@mmarchini
Copy link
Contributor

@rvagg @mhdawson @jbergstroem y'all should've received an invite for the nodejs-foundation npm account to join the orgs above. The invite was sent to build@iojs.org.

@mcollina
Copy link
Member

mcollina commented Sep 5, 2020

Can I get access? I would like to add readable-stream as well.

@mmarchini
Copy link
Contributor

I think it makes sense to add everyone from TSC (or everyone who wants to) as admins to the orgs (and maybe add it as part of our onboarding/offboarding)

@rvagg
Copy link
Member

rvagg commented Sep 9, 2020

I got 3 invites in my email but they all lead to 404s. Maybe just let me know if I need to npm owner add anything?

@mmarchini
Copy link
Contributor

The links probably expired, or you need to be logged in as nodejs-foundation on npm for the links to work. I don't think you can use npm owner add to add the nodejs-foundation account as owner of the nodejs org unless you rvagg is an owner of the org (which is not the case, Myles is the owner now).

@MylesBorins
Copy link
Contributor

you can have multiple owners. I've escalated rvagg to also be an owner. There are still invites out for nodejs-foundation

@mhdawson
Copy link
Member

I can try to log in as nodejs-foundation a bit later to try to resolve that side of things.

@mhdawson
Copy link
Member

Still on my TODO list.

@mmarchini
Copy link
Contributor

mmarchini commented Sep 14, 2020

I can do this tomorrow after the build infra onboarding.

Also, for whoever ends up doin this, it's probably worth to coordinate with Myles via Slack so he can re-send the invite (suggesting Slack because real-time communication might make this easier).

@mhdawson
Copy link
Member

@mmarchini if you are going to do this let me know, otherwise I might try to schedule a time with Myles on Friday to do it.

@mhdawson
Copy link
Member

mhdawson commented Sep 17, 2020

Got Myles to resend and the nodejs-foundation npm use is now a member of the node organisation. I terms of owners I think it makes sense for a number of TSC members (or all to be the owners).

@MylesBorins
Copy link
Contributor

please add me

@mmarchini
Copy link
Contributor

please add me too :)

@mhdawson
Copy link
Member

I'm confused by the please add me from @MylesBorins as I thought he was the one who would be adding people ?

@mhdawson
Copy link
Member

primarily based on #545 (comment)

@mhdawson
Copy link
Member

please add me too :)

@MylesBorins
Copy link
Contributor

@mhdawson I misunderstood, I thought you meant to add more people to the nodejs-foundation org 😂

@mhdawson
Copy link
Member

@MylesBorins there is no nodejs-foundation org. It is simply a user which we add as a backup to be able to add/manage collaborators on Node.js packages in case the other collaborators are no longer available.

@mmarchini
Copy link
Contributor

This is the current membership of the nodejs org on npm:

image

@mhdawson
Copy link
Member

@mmarchini thanks for grabbing it. I think it should be likely be the TSC or subset as owners.

@MylesBorins
Copy link
Contributor

@mhdawson was is your current up to date npm account?

@mhdawson
Copy link
Member

mhdawson1

@mmarchini
Copy link
Contributor

I believe this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants