Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lines with long URLs #24

Closed
vsemozhetbyt opened this issue Nov 18, 2017 · 3 comments
Closed

Lines with long URLs #24

vsemozhetbyt opened this issue Nov 18, 2017 · 3 comments

Comments

@vsemozhetbyt
Copy link

Should we alleviate the 72 characters rule for lines with long URLs?

Example: nodejs/node#17107
@Tiriel
Copy link

Tiriel commented Nov 18, 2017

Well, AFAIC I'd say yes, it does seem logical otherwise the link will be broken, but I think it should first be discussed as meta in core, or wherever the contribution guides are discussed.

I don't think that's quite up to us to decide to change the validation rules on our own.

@vsemozhetbyt vsemozhetbyt mentioned this issue Nov 18, 2017
Closed
@vsemozhetbyt
Copy link
Author

Core issue: nodejs/node#17116

@vsemozhetbyt vsemozhetbyt mentioned this issue Apr 22, 2018
Closed
3 tasks
vsemozhetbyt added a commit to nodejs/node that referenced this issue Apr 22, 2018
@vsemozhetbyt
meta: document commit msg exception for long URLs
2060787 
PR-URL: #20207
Fixes: #17116
Refs: nodejs/core-validate-commit#24
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@vsemozhetbyt
Copy link
Author

@Tiriel Exception approved and landed: nodejs/node#20207

jasnell pushed a commit to nodejs/node that referenced this issue Apr 23, 2018
@vsemozhetbyt @jasnell
meta: document commit msg exception for long URLs
d591a59 
PR-URL: #20207
Fixes: #17116
Refs: nodejs/core-validate-commit#24
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lundibundi lundibundi mentioned this issue Nov 2, 2018
Merged
joyeecheung pushed a commit that referenced this issue Nov 2, 2018
@addaleax @joyeecheung
rules: skip line-length rule for URLs and quoted lines (#30)
029fc30 
Fixes: #24
richardlau pushed a commit to richardlau/core-validate-commit that referenced this issue Dec 15, 2018
@addaleax @richardlau
rules: skip line-length rule for URLs and quoted lines (nodejs#30)
5ef341d 
Fixes: nodejs#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsemozhetbyt @Tiriel