Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: fix badge URLs #36

Merged
merged 2 commits into from
Nov 19, 2018
Merged

readme: fix badge URLs #36

merged 2 commits into from
Nov 19, 2018

Conversation

targos
Copy link
Member

@targos targos commented Nov 18, 2018

No description provided.

README.md Outdated
[![Build Status](https://travis-ci.org/evanlucas/core-validate-commit.svg)](https://travis-ci.org/evanlucas/core-validate-commit)
[![Coverage Status](https://coveralls.io/repos/evanlucas/core-validate-commit/badge.svg?branch=master&service=github)](https://coveralls.io/github/evanlucas/core-validate-commit?branch=master)
[![Build Status](https://travis-ci.org/nodejs/core-validate-commit.svg)](https://travis-ci.org/nodejs/core-validate-commit)
[![Coverage Status](https://coveralls.io/repos/nodejs/core-validate-commit/badge.svg?branch=master&service=github)](https://coveralls.io/github/nodejs/core-validate-commit?branch=master)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the coverage badge/link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I reverted that change, though it feels weird to have to keep the old reference.

@joyeecheung joyeecheung merged commit 64c7867 into master Nov 19, 2018
richardlau pushed a commit to richardlau/core-validate-commit that referenced this pull request Dec 15, 2018
richardlau added a commit to richardlau/core-validate-commit that referenced this pull request Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants