Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: add test_runner subsystem #96

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 14, 2022

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #96 (858e5f1) into main (4b63657) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          19       19           
  Lines         458      458           
=======================================
  Hits          430      430           
  Misses         28       28           
Impacted Files Coverage Δ
lib/rules/subsystem.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b63657...858e5f1. Read the comment docs.

@Trott
Copy link
Member

Trott commented Mar 15, 2022

This might be obvious, but I think we should publish this immediately. We can always remove it if the test_runner module doesn't end landing, or update it if the name changes. I'd rather not have core-validate-commit be the thing that prevents easy landing of the PR.

@richardlau richardlau merged commit e5dd803 into nodejs:main Mar 15, 2022
@richardlau
Copy link
Member

Published in core-validate-commit@3.16.0.

@aduh95 aduh95 deleted the test_runner-subsystem branch March 15, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants