Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Overflow detection on chunk extensions #34

Closed
scunningham opened this issue Feb 11, 2011 · 1 comment
Closed

Overflow detection on chunk extensions #34

scunningham opened this issue Feb 11, 2011 · 1 comment

Comments

@scunningham
Copy link

There's a TODO in the code:

/* just ignore this shit. TODO check for overflow */

Allowing unbounded chunk extensions is hardly the end of the world, but doesn't hurt to address it. Easiest way I found was to treat the state for the chunk headers as if they were regular headers, and have the parser bail if the total amount of data in a chunk header is larger then HTTP_MAX_HEADER_SIZE.

See chunk_ext_overflow

@scunningham
Copy link
Author

Fix pushed.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant