Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 bt does not work #55

Closed
Fishrock123 opened this issue Nov 21, 2016 · 7 comments
Closed

v8 bt does not work #55

Fishrock123 opened this issue Nov 21, 2016 · 7 comments
Labels

Comments

@Fishrock123
Copy link

Fishrock123 commented Nov 21, 2016

llnode: v1.2.0


OS X: 10.10.5

uname -a
Darwin Jeremiahs-MacBook-Pro.local 14.5.0 Darwin Kernel Version 14.5.0: Sun Sep 25 22:07:15 PDT 2016; root:xnu-2782.50.9~1/RELEASE_X86_64 x86_64

lldb -v
lldb-340.4.119

XCode version: 7.2 (7C68)

@indutny
Copy link
Member

indutny commented Nov 21, 2016

Alright, the version of lldb is most likely a culprit. Have you installed llnode from homebrew?

@Fishrock123
Copy link
Author

@indutny Yes:

brew --version
Homebrew 1.1.1-53-gc7267b1
Homebrew/homebrew-core (git revision 586c; last commit 2016-11-21)

@indutny
Copy link
Member

indutny commented Nov 21, 2016

@Fishrock123 yeah, it won't work I'm afraid. We need to figure out the way to use older lldb when building it from homebrew. Right now it picks the same for all OS X:

https://github.com/Homebrew/homebrew-core/blob/master/Formula/llnode.rb#L22-L25

I'll see if can figure something out.

@indutny
Copy link
Member

indutny commented Nov 21, 2016

@Fishrock123 meanwhile you may want to use build instructions for previous lldb version:

https://github.com/nodejs/llnode/tree/142465c3dfa4b884358e8780df75583512a318aa#os-x

@indutny indutny mentioned this issue Nov 21, 2016
@indutny
Copy link
Member

indutny commented Nov 21, 2016

We managed to fix it with a patched homebrew formula:

diff --git a/Formula/llnode.rb b/Formula/llnode.rb
index f69abd2..d277576 100644
--- a/Formula/llnode.rb
+++ b/Formula/llnode.rb
@@ -20,8 +20,15 @@ class Llnode < Formula
   end

   resource "lldb" do
-    url "https://github.com/llvm-mirror/lldb.git",
-        :revision => "839b868e2993dcffc7fea898a1167f1cec097a82"
+    if MacOS.version >= :el_capitan
+      url "https://github.com/llvm-mirror/lldb.git",
+          :revision => "839b868e2993dcffc7fea898a1167f1cec097a82"
+    else
+      # Yosemite has way older lldb which is not available on github for some
+      # reason
+      url "http://llvm.org/svn/llvm-project/lldb/tags/RELEASE_34/final/",
+          :using => :svn
+    end
   end

   def install

Will include these changes in next release.

@indutny
Copy link
Member

indutny commented Nov 22, 2016

Opened Homebrew/homebrew-core#7137 to gather feedback from Homebrew team.

@indutny
Copy link
Member

indutny commented Nov 24, 2016

Fixed by Homebrew/homebrew-core@f399eac.

@indutny indutny closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants