ToString/ToObject deprecated?

[brd]

I am getting the following build error when using Clang 6.0.1

gmake: Entering directory '/usr/home/raspberry/node_modules/curve25519-n/build'
  CXX(target) Release/obj.target/curve/node_curve.o
In file included from ../node_curve.cc:10:
../../nan/nan.h:1064:44: warning: 'ToString' is deprecated: Use maybe version [-Wdeprecated-declarations]
      v8::Local<v8::String> string = from->ToString(v8::Isolate::GetCurrent());
                                           ^

../node_curve.cc:18:70: warning: 'ToObject' is deprecated: Use maybe version [-Wdeprecated-declarations]
  unsigned char* arg0 = (unsigned char*) node::Buffer::Data(info[0]->ToObject());
                                                                     ^
/root/.node-gyp/11.2.0/include/node/v8.h:2549:10: note: 'ToObject' has been explicitly marked deprecated here
  inline V8_DEPRECATED("Use maybe version", Local<Object> ToObject() const);
         ^

[kkoopa]

You are using an outdated version of NAN.

[brd]

I still see them: https://github.com/nodejs/nan/blob/master/nan.h#L1067

[kkoopa]

That function is not deprecated. https://github.com/nodejs/node/blob/v11.6.0/deps/v8/include/v8.h#L2521-L2522

[stiv-yakovenko]

It is kind of deprecated, now you do it like this:

   v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();
   auto bufferObj = info[0]->ToObject(context).ToLocalChecked();
    size_t bufferLength = Buffer::Length(bufferObj);