-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull latest commits from node core #32
Pull latest commits from node core #32
Conversation
PR-URL: nodejs/node#43989 Refs: nodejs/node#43554 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> (cherry picked from commit 7a18ee8315ecc8ad1a1316ff1c951694f8e8f7a4)
probably these should be added as well - both waiting for 48 hours to pass |
PR-URL: nodejs/node#43997 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> (cherry picked from commit f0639eb8bad739b27b7cdefef4fac8e48c889f16)
PR-URL: nodejs/node#43976 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit 60da0a1b364efdd84870269d23b39faa12fb46d8)
PR-URL: nodejs/node#43977 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit 26e27424ad91c60a44d3d4c58b62a39b555ba75d)
63fcecf
to
4071052
Compare
PR-URL: nodejs/node#43998 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit a3e110820ff98702e1761831e7beaf0f5f1f75e7)
return | ||
} | ||
let stdout = '' | ||
const child = spawn(process.execPath, ['--test', file]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this pass in node 16/14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-core-test/test/common/index.js
Line 9 in 4071052
process.execPath = path.resolve(__dirname, '..', '..', bin.test) |
Opening as draft as I'd like to pull nodejs/node#43997 as well before releasing a new version.