Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iteritems() -> items() in compile_commands_json.py #1947

Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 27, 2019

Fixes: #1946

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

richardlau and others added 4 commits October 24, 2019 14:54
The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

PR-URL: nodejs#1934
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
* Fix TypeError in XcodeVersion()

* fixup: Consistantly use tuple unpacking

* fixup: Consistantly use tuple unpacking
@cclauss cclauss added the Python label Oct 27, 2019
@gengjiawen
Copy link
Member

Can you rebase this ? Thanks. @cclauss

rvagg pushed a commit that referenced this pull request Oct 30, 2019
PR-URL: #1947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg
Copy link
Member

rvagg commented Oct 30, 2019

picked off the HEAD commit and landed as c0282da
@cclauss I think you've been preparing separate pull requests off the same branch, or inheriting previous branches for newer PRs rather than master.

@rvagg rvagg closed this Oct 30, 2019
rvagg pushed a commit that referenced this pull request Nov 18, 2019
PR-URL: #1947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cclauss cclauss deleted the fix-iteritems-in-compile_commands_json.py branch June 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile_commands_json breaks on Python3
4 participants