Skip to content

Commit

Permalink
Revert "src, tools: add debug symbols for node internals"
Browse files Browse the repository at this point in the history
This reverts commit 446c1ec.

Reverted for breaking `make test-v8`.  The "find all relevant system
headers" logic in `tools/gen-postmortem-metadata.py` needs more work.

Also reverts commit e46c3f7.
("tools: fix typo in gen-postmortem-metadata.py".)

PR-URL: #17272
Refs: #14901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheusdot@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
bnoordhuis committed Nov 23, 2017
1 parent bd0e36d commit 088bba3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 225 deletions.
26 changes: 1 addition & 25 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@

'dependencies': [
'node_js2c#host',
'deps/nghttp2/nghttp2.gyp:nghttp2'
],

'includes': [
Expand Down Expand Up @@ -299,7 +298,6 @@
# node.gyp is added to the project by default.
'common.gypi',
'<(SHARED_INTERMEDIATE_DIR)/node_javascript.cc',
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
],

'variables': {
Expand Down Expand Up @@ -972,29 +970,7 @@
}]]
}],
]
},
{
'target_name': 'node_postmortem_metadata',
'type': 'none',
'toolsets': ['host'],
'actions': [
{
'action_name': 'gen-postmortem-metadata',
'process_outputs_as_sources': 1,
'inputs': [
'./tools/gen-postmortem-metadata.py',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/node-debug-support.cc',
],
'action': [
'python',
'./tools/gen-postmortem-metadata.py',
'<@(_outputs)',
]
}
]
},
}
], # end targets

'conditions': [
Expand Down
200 changes: 0 additions & 200 deletions tools/gen-postmortem-metadata.py

This file was deleted.

0 comments on commit 088bba3

Please sign in to comment.