Skip to content

Commit

Permalink
test: fix spelling in test case comments
Browse files Browse the repository at this point in the history
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
  • Loading branch information
tniessen authored and MylesBorins committed Mar 30, 2018
1 parent cbc8561 commit 1043b6f
Show file tree
Hide file tree
Showing 45 changed files with 61 additions and 60 deletions.
4 changes: 2 additions & 2 deletions test/abort/test-http-parser-consume.js
Expand Up @@ -11,12 +11,12 @@ if (process.argv[2] === 'child') {
const rr = get({ port: server.address().port }, common.mustCall(() => {
// This bad input (0) should abort the parser and the process
rr.parser.consume(0);
// This line should be unreachanble.
// This line should be unreachable.
assert.fail('this should be unreachable');
}));
}));
} else {
// super-proces
// super-process
const child = spawn(process.execPath, [__filename, 'child']);
child.stdout.on('data', common.mustNotCall());

Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/hook-checks.js
Expand Up @@ -11,7 +11,7 @@ require('../common');
* @param {Object} activity including timestamps for each life time event,
* i.e. init, before ...
* @param {Object} hooks the expected life time event invocations with a count
* indicating how oftn they should have been invoked,
* indicating how often they should have been invoked,
* i.e. `{ init: 1, before: 2, after: 2 }`
* @param {String} stage the name of the stage in the test at which we are
* checking the invocations
Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/test-internal-nexttick-default-trigger.js
Expand Up @@ -3,7 +3,7 @@
const common = require('../common');

// This tests ensures that the triggerId of both the internal and external
// nexTick function sets the triggerAsyncId correctly.
// nextTick function sets the triggerAsyncId correctly.

const assert = require('assert');
const async_hooks = require('async_hooks');
Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/test-pipeconnectwrap.js
Expand Up @@ -53,7 +53,7 @@ function onlisten() {
const awaitOnconnectCalls = new Set(['server', 'client']);
function maybeOnconnect(source) {
// both server and client must call onconnect. On most OS's waiting for
// the client is sufficient, but on CertOS 5 the sever needs to respond too.
// the client is sufficient, but on CentOS 5 the sever needs to respond too.
assert.ok(awaitOnconnectCalls.size > 0);
awaitOnconnectCalls.delete(source);
if (awaitOnconnectCalls.size > 0) return;
Expand Down
2 changes: 1 addition & 1 deletion test/async-hooks/verify-graph.js
Expand Up @@ -32,7 +32,7 @@ function pruneTickObjects(activities) {
foundTickObject = true;

// point all triggerAsyncIds that point to the tickObject
// to its triggerAsyncId and findally remove it from the activities
// to its triggerAsyncId and finally remove it from the activities
const tickObject = activities[tickObjectIdx];
const newTriggerId = tickObject.triggerAsyncId;
const oldTriggerId = tickObject.uid;
Expand Down
2 changes: 1 addition & 1 deletion test/common/index.js
Expand Up @@ -82,7 +82,7 @@ if (process.env.NODE_TEST_WITH_ASYNC_HOOKS) {
const async_wrap = process.binding('async_wrap');

process.on('exit', () => {
// itterate through handles to make sure nothing crashes
// iterate through handles to make sure nothing crashes
for (const k in initHandles)
util.inspect(initHandles[k]);
});
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/net-fd-passing-receiver.js
Expand Up @@ -45,7 +45,7 @@ receiver = net.createServer(function(socket) {
});
});

/* To signal the test runne we're up and listening */
/* To signal the test runner we're up and listening */
receiver.on('listening', function() {
console.log('ready');
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-hooks-http-agent.js
Expand Up @@ -8,7 +8,7 @@ const http = require('http');
// Checks that an http.Agent properly asyncReset()s a reused socket handle, and
// re-assigns the fresh async id to the reused `net.Socket` instance.

// Make sure a single socket is transpartently reused for 2 requests.
// Make sure a single socket is transparently reused for 2 requests.
const agent = new http.Agent({
keepAlive: true,
keepAliveMsecs: Infinity,
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-async-hooks-promise-enable-disable.js
Expand Up @@ -11,13 +11,13 @@ let p_inits = 0;
common.crashOnUnhandledRejection();

// Not useful to place common.mustCall() around 'exit' event b/c it won't be
// able to check it anway.
// able to check it anyway.
process.on('exit', (code) => {
if (code !== 0)
return;
if (p_er !== null)
throw p_er;
// Expecint exactly 2 PROMISE types to reach init.
// Expecting exactly 2 PROMISE types to reach init.
assert.strictEqual(p_inits, EXPECTED_INITS);
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-wrap-pop-id-during-load.js
Expand Up @@ -8,7 +8,7 @@ if (process.argv[2] === 'async') {
throw new Error();
}
(async function() { await fn(); })();
// While the above should error, just in case it dosn't the script shouldn't
// While the above should error, just in case it doesn't the script shouldn't
// fork itself indefinitely so return early.
return;
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-buffer-fill.js
Expand Up @@ -344,7 +344,7 @@ Buffer.alloc(8, '');
return 0;
} else {
elseWasLast = true;
// Once buffer.js calls the C++ implemenation of fill, return -1
// Once buffer.js calls the C++ implementation of fill, return -1
return -1;
}
}
Expand Down Expand Up @@ -377,7 +377,7 @@ assert.throws(() => {
return 1;
} else {
elseWasLast = true;
// Once buffer.js calls the C++ implemenation of fill, return -1
// Once buffer.js calls the C++ implementation of fill, return -1
return -1;
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-includes.js
Expand Up @@ -137,7 +137,7 @@ assert.strictEqual(
);


// test usc2 encoding
// test ucs2 encoding
let twoByteString = Buffer.from('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');

assert(twoByteString.includes('\u0395', 4, 'ucs2'));
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-indexof.js
Expand Up @@ -553,7 +553,7 @@ assert.strictEqual(511, longBufferString.lastIndexOf(pattern, 1534));
// "yolo swag swag yolo swag yolo yolo swag" ..., goes on for about 5MB.
// This is hard to search because it all looks similar, but never repeats.

// countBits returns the number of bits in the binary reprsentation of n.
// countBits returns the number of bits in the binary representation of n.
function countBits(n) {
let count;
for (count = 0; n > 0; count++) {
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-buffer-read.js
Expand Up @@ -20,11 +20,11 @@ function read(buff, funx, args, expected) {

}

// testing basic functionality of readDoubleBE() and readDOubleLE()
// testing basic functionality of readDoubleBE() and readDoubleLE()
read(buf, 'readDoubleBE', [1], -3.1827727774563287e+295);
read(buf, 'readDoubleLE', [1], -6.966010051009108e+144);

// testing basic functionality of readFLoatBE() and readFloatLE()
// testing basic functionality of readFloatBE() and readFloatLE()
read(buf, 'readFloatBE', [1], -1.6691549692541768e+37);
read(buf, 'readFloatLE', [1], -7861303808);

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-child-process-internal.js
Expand Up @@ -32,7 +32,7 @@ if (process.argv[2] === 'child') {
//send non-internal message containing PREFIX at a non prefix position
process.send(normal);

//send inernal message
//send internal message
process.send(internal);

process.exit(0);
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-child-process-send-returns-boolean.js
Expand Up @@ -14,7 +14,7 @@ const fixtures = require('../common/fixtures');
const subScript = fixtures.path('child-process-persistent.js');

{
// Test `send` return value on `fork` that opens and IPC by deafult.
// Test `send` return value on `fork` that opens and IPC by default.
const n = fork(subScript);
// `subprocess.send` should always return `true` for the first send.
const rv = n.send({ h: 'w' }, (err) => { if (err) assert.fail(err); });
Expand All @@ -31,12 +31,12 @@ const subScript = fixtures.path('child-process-persistent.js');
const server = net.createServer(common.mustNotCall()).listen(0, () => {
const handle = server._handle;

// Sending a handle and not giving the tickQueue time to acknoladge should
// Sending a handle and not giving the tickQueue time to acknowledge should
// create the internal backlog, but leave it empty.
const rv1 = s.send('one', handle, (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv1, true);
// Since the first `send` included a handle (should be unackoladged),
// we can safly queue up only one more message.
// Since the first `send` included a handle (should be unacknowledged),
// we can safely queue up only one more message.
const rv2 = s.send('two', (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv2, true);
// The backlog should now be indicate to backoff.
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-deprecated.js
Expand Up @@ -14,7 +14,7 @@ common.expectWarning('DeprecationWarning', [

// Accessing the deprecated function is enough to trigger the warning event.
// It does not need to be called. So the assert serves the purpose of both
// triggering the warning event and confirming that the deprected function is
// triggering the warning event and confirming that the deprecated function is
// mapped to the correct non-deprecated function.
assert.strictEqual(crypto.Credentials, tls.SecureContext);
assert.strictEqual(crypto.createCredentials, tls.createSecureContext);
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-fips.js
Expand Up @@ -91,7 +91,7 @@ testHelper(
// to try to call the fips setter, to try to detect this situation, as
// that would throw an error:
// ("Error: Cannot set FIPS mode in a non-FIPS build.").
// Due to this uncertanty the following tests are skipped when configured
// Due to this uncertainty the following tests are skipped when configured
// with --shared-openssl.
if (!sharedOpenSSL()) {
// OpenSSL config file should be able to turn on FIPS mode
Expand Down
Expand Up @@ -25,7 +25,7 @@ if (process.argv[2] === 'child') {
// is not properly flushed in V8's Isolate::Throw right before the
// process aborts due to an uncaught exception, and thus the error
// message representing the error that was thrown cannot be read by the
// parent process. So instead of parsing the child process' stdandard
// parent process. So instead of parsing the child process' standard
// error, the parent process will check that in the case
// --abort-on-uncaught-exception was passed, the process did not exit
// with exit code RAN_UNCAUGHT_EXCEPTION_HANDLER_EXIT_CODE.
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-event-emitter-remove-listeners.js
Expand Up @@ -119,10 +119,10 @@ function listener2() {}

// listener4 will still be called although it is removed by listener 3.
ee.emit('hello');
// This is so because the interal listener array at time of emit
// This is so because the internal listener array at time of emit
// was [listener3,listener4]

// Interal listener array [listener3]
// Internal listener array [listener3]
ee.emit('hello');
}

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-access.js
Expand Up @@ -28,7 +28,7 @@ createFileWithPerms(readWriteFile, 0o666);
* The change of user id is done after creating the fixtures files for the same
* reason: the test may be run as the superuser within a directory in which
* only the superuser can create files, and thus it may need superuser
* priviledges to create them.
* privileges to create them.
*
* There's not really any point in resetting the process' user id to 0 after
* changing it to 'nobody', since in the case that the test runs without
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-agent-keepalive.js
Expand Up @@ -89,7 +89,7 @@ function remoteClose() {
process.nextTick(common.mustCall(() => {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name].length, 1);
// waitting remote server close the socket
// waiting remote server close the socket
setTimeout(common.mustCall(() => {
assert.strictEqual(agent.sockets[name], undefined);
assert.strictEqual(agent.freeSockets[name], undefined,
Expand All @@ -102,7 +102,7 @@ function remoteClose() {
}

function remoteError() {
// remove server will destroy ths socket
// remote server will destroy the socket
const req = get('/error', common.mustNotCall());
req.on('error', common.mustCall((err) => {
assert(err);
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http-extra-response.js
Expand Up @@ -51,7 +51,6 @@ const server = net.createServer(function(socket) {

if (postBody.includes('\r\n')) {
socket.write(fullResponse);
// omg, I wrote the response twice, what a terrible HTTP server I am.
socket.end(fullResponse);
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-server-push-disabled.js
Expand Up @@ -42,7 +42,7 @@ server.listen(0, common.mustCall(() => {
options);
const req = client.request({ ':path': '/' });

// Because push stream sre disabled, this must not be called.
// Because push streams are disabled, this must not be called.
client.on('stream', common.mustNotCall());

req.resume();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-agent-secure-protocol.js
Expand Up @@ -42,7 +42,7 @@ server.listen(0, common.mustCall(function() {
}, common.mustCall(function(res) {
res.resume();
globalAgent.once('free', common.mustCall(function() {
// Verify that two keep-alived connections are created
// Verify that two keep-alive connections are created
// due to the different secureProtocol settings:
const keys = Object.keys(globalAgent.freeSockets);
assert.strictEqual(keys.length, 2);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-socket-options.js
Expand Up @@ -61,7 +61,7 @@ server_http.listen(0, function() {
});

// Then try https server (requires functions to be
// mirroed in tls.js's CryptoStream)
// mirrored in tls.js's CryptoStream)

const server_https = https.createServer(options, function(req, res) {
console.log('got HTTPS request');
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-internal-fs-syncwritestream.js
Expand Up @@ -31,7 +31,7 @@ const filename = path.join(common.tmpDir, 'sync-write-stream.txt');
assert.strictEqual(stream.listenerCount('end'), 1);
}

// Verfiy that the file will be written synchronously.
// Verify that the file will be written synchronously.
{
const fd = fs.openSync(filename, 'w');
const stream = new SyncWriteStream(fd);
Expand All @@ -54,7 +54,7 @@ const filename = path.join(common.tmpDir, 'sync-write-stream.txt');
assert.strictEqual(stream.destroySoon(), true);
}

// Verfit that the 'end' event listener will also destroy the stream.
// Verify that the 'end' event listener will also destroy the stream.
{
const fd = fs.openSync(filename, 'w');
const stream = new SyncWriteStream(fd);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-listen-error.js
Expand Up @@ -25,5 +25,5 @@ const net = require('net');

const server = net.createServer(function(socket) {
});
server.listen(1, '1.1.1.1', common.mustNotCall()); // EACCESS or EADDRNOTAVAIL
server.listen(1, '1.1.1.1', common.mustNotCall()); // EACCES or EADDRNOTAVAIL
server.on('error', common.mustCall());
2 changes: 1 addition & 1 deletion test/parallel/test-net-pipe-connect-errors.js
Expand Up @@ -37,7 +37,7 @@ if (common.isWindows) {
emptyTxt = fixtures.path('empty.txt');
} else {
common.refreshTmpDir();
// Keep the file name very short so tht we don't exceed the 108 char limit
// Keep the file name very short so that we don't exceed the 108 char limit
// on CI for a POSIX socket. Even though this isn't actually a socket file,
// the error will be different from the one we are expecting if we exceed the
// limit.
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-net-write-after-close.js
Expand Up @@ -39,7 +39,7 @@ const server = net.createServer(common.mustCall(function(socket) {

server.listen(0, function() {
const client = net.connect(this.address().port, function() {
// cliend.end() will close both the readable and writable side
// client.end() will close both the readable and writable side
// of the duplex because allowHalfOpen defaults to false.
// Then 'end' will be emitted when it receives a FIN packet from
// the other side.
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-os.js
Expand Up @@ -113,7 +113,7 @@ is.string(arch);
assert.ok(arch.length > 0);

if (!common.isSunOS) {
// not implemeneted yet
// not implemented yet
assert.ok(os.loadavg().length > 0);
assert.ok(os.freemem() > 0);
assert.ok(os.totalmem() > 0);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-promises-unhandled-rejections.js
Expand Up @@ -293,7 +293,7 @@ asyncTest('While inside setImmediate, catching a rejected promise derived ' +
});
});

// State adapation tests
// State adaptation tests
asyncTest('catching a promise which is asynchronously rejected (via ' +
'resolution to an asynchronously-rejected promise) prevents' +
' unhandledRejection', function(done) {
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-readline-interface.js
Expand Up @@ -812,7 +812,7 @@ function isWarned(emitter) {
assert.strictEqual(isWarned(process.stdout._events), false);
}

// can create a new readline Interface with a null output arugument
// can create a new readline Interface with a null output argument
{
const fi = new FakeInput();
const rli = new readline.Interface(
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-repl.js
Expand Up @@ -304,7 +304,7 @@ function error_test() {
{ client: client_unix,
send: '/(.)(.)(.)(.)(.)(.)(.)(.)(.)/.test(\'123456789\')\n',
expect: `true\n${prompt_unix}` },
// the following test's result depends on the RegEx's match from the above
// the following test's result depends on the RegExp's match from the above
{ client: client_unix,
send: 'RegExp.$1\nRegExp.$2\nRegExp.$3\nRegExp.$4\nRegExp.$5\n' +
'RegExp.$6\nRegExp.$7\nRegExp.$8\nRegExp.$9\n',
Expand Down
3 changes: 2 additions & 1 deletion test/parallel/test-require-symlink.js
Expand Up @@ -38,7 +38,8 @@ function copyDir(source, target) {
copyDir(fixtureSource, tmpDirTarget);

// Move to tmp dir and do everything with relative paths there so that the test
// doesn't incorrectly fail due to a symlink somewhere else in the absolte path.
// doesn't incorrectly fail due to a symlink somewhere else in the absolute
// path.
process.chdir(common.tmpDir);

const linkDir = path.join(dirName,
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-stream-transform-final-sync.js
Expand Up @@ -7,7 +7,7 @@ let state = 0;

/*
What you do
var stream = new tream.Transform({
var stream = new stream.Transform({
transform: function transformCallback(chunk, _, next) {
// part 1
this.push(chunk);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-stream-transform-final.js
Expand Up @@ -7,7 +7,7 @@ let state = 0;

/*
What you do
var stream = new tream.Transform({
var stream = new stream.Transform({
transform: function transformCallback(chunk, _, next) {
// part 1
this.push(chunk);
Expand Down

0 comments on commit 1043b6f

Please sign in to comment.