Skip to content

Commit

Permalink
build: don't use -latomic on macOS
Browse files Browse the repository at this point in the history
Fixes build when using open-source clang.

Builds using Apple clang from Xcode v7 and later were already working,
due to the fact that node's build system misidentifies their
llvm_version as "0.0" and thus the flag wasn't being added.

PR-URL: #30099
Fixes: #30093
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
ryandesign authored and BridgeAR committed Jan 2, 2020
1 parent c7f328f commit 4bd0d8c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@
'-Wl,-bnoerrmsg',
],
}],
['OS in ("linux", "mac") and llvm_version != "0.0"', {
['OS == "linux" and llvm_version != "0.0"', {
'libraries': ['-latomic'],
}],
],
Expand Down

0 comments on commit 4bd0d8c

Please sign in to comment.