-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CallbackScope should not have NODE_EXTERN? #20758
Comments
That's a cmake-js bug. I had a quick look at its sources and I don't see it defining |
I get a lot of different warnings that are also 4251 with BUILDING_NODE_EXTENSION enabled.... This is the ONLY line
|
Version: Since dec, 2017...
This wasn't an issue previously.
(Sorry for vagueness)
At the bottom is the result of a build of an addon.
https://github.com/nodejs/node/blob/master/src/node.h#L663
Deleting NODE_EXTERN on that line of code fixes the warning.
(rather than modifying the V8 headers to have NODE_EXTERN on TryCatch)
Also #15570
#15570 (comment)
This is hidden by node-gyp which, by default, enables disable warning C4251 in windows.
cmake-js does not auto-disable this warning... so it shows up for those builds.
The text was updated successfully, but these errors were encountered: