-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http perfomance regression in Node 8.10 and 8.11. #20798
Comments
cc @nodejs/v8 @nodejs/http |
Looks like this came with the V8 update (6.2) in v8.x. Wonder if we can do anything, perhaps there's a patch to float. I did notice that /cc @nodejs/v8 |
|
@hashseed was this changed between 6.1 and 6.2? Also, there is no difference between the two with Node 10 / v8 6.6. |
I don't think so. Are you saying that Node 10 does not have this regression? |
I think it is there but it gets compensated by something else (the new parallel GC?). There is a tiny difference on my system, but it is not this noticeable. |
We're seeing the same issue. We were seeing 150ms latency and it shot up from 150 to 30,000ms. Immediately rolled back. Thanks to @mcollina we plan to use 8.9.4 until this is resolved. Is there any update on this or road map? |
@nitrocode the magnitude of the latency impact you mentioned is too substantial for it to be the same issue. I suspect a long GC pause for a latency impact that large. You can run with |
I am closing this since it seems to only impact Node.js v8.x. Node.js v8.x is end-of-life and won't receive any updates anymore. Please reopen in case it also applies to other Node.js release lines. |
There has been a regression on using
res.setHeader()
with a CamelCase header like'Content-Type'
vs'content-type'
.Consider this example:
This leads us to the following benchmark:
However if we use a camel-cased header, we have:
I would note that this difference is not present in Node 8.9.4.
I've also created a few flamegraphs:
Node 8.11.1 camel cased:
Node 8.11.1 lowercase:
Node 8.9.4 camel cased:
As you can see the
setHeader
method is not "hot" in neither 8.11.1 and 8.9.4.The text was updated successfully, but these errors were encountered: