-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core.h not found #20921
Comments
My guess is that header isn't included in the headers tarball that node-gyp downloads. |
More info: The Node core |
They (#20789 added others) aren't: Lines 161 to 192 in 5cbb905
I'm not sure if the correct fix is to add them to the install script, or take them out of |
Probably the latter. |
pretty big bug! pls fix asap |
Likely best to move the core.h reference to node_internals.h. |
Actually, I take that back... fixing the install.py is likely the better choice. Investigating now. |
Fix in #20925 ... once that lands a new 10.2.1 release needs to be spun up. |
My |
Just updated to node 10.2 and have same issue with missing core.h header. |
I have now updated |
I just copied manually from git rep core.h into ~/node-gyp/10.2.0/include/node/, and then I also had to copy callback_scope.h and exceptions.h. However after I did that, I got again error with include macro NODE_MODULE_X (node::addon_register_func) (regfunc), and my c++ module still fails to compile. |
Hmm, I was able to compile with clang, but compilation with gcc fails. Everything else on my system compiles just fine with gcc :-( |
Note: fix has been identified and is in review. We will be verifying the fix and if it doesn't work we can revert the commit that's at fault and revisit that change. Either one should land today and an updated release will be coming out quickly. |
When does a new docker image get made for 10.2.1? |
@kingjerod I guess it's on it's way? nodejs/docker-node#759 |
hey good work guys but how could NodeJS be released without running basic tests to build popular native modules? how? explain! |
Our regular ci runs do not currently include adequate coverage of native modules built using the tarball. We've got an issue open to fix that and we always welcome pull requests that help. |
Our CI also got brought down by this bug....Plz fix it asap 🙏 |
Already fixed. Already released. |
Hmm not showing up here and my CI keeps grabbing 10.2.0 |
Docker images usually lag just a bit.
On May 24, 2018 21:27, "Jerod King" <notifications@github.com> wrote:
Hmm not showing up here and my CI keeps grabbing 10.2.0
https://hub.docker.com/_/node/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#20921 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2eahESpB8NkY-fjI_zKsEdczSI56hks5t14gWgaJpZM4ULamU>
.
|
PR for official image is still open: docker-library/official-images#4394 |
Here's the workaround I use until the fixed version will be available: https://gist.github.com/moisadoru/3c894abf13474f48b5c3ce4d84a64e4e |
Should be fixed in 10.2.1: nodejs/node#20921.
Should be fixed in 10.2.1: nodejs/node#20921.
I've installed node 10.2.1 to fix the core.h issue with zeromq, but i'm running into this problem :
same goes with npm |
in my case: node 10.2 install error, but ok with node 11.6 |
Resolves "core.h not found": nodejs/node#20921
I noticed using Node 10.2.0 that the
sleep
package now fails to build with the following error(it didn't fail with 10.1.0):
The problem line appears to be
node/src/node.h
Line 53 in 82f1811
The text was updated successfully, but these errors were encountered: