Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threadpool monitoring / metrics #22957

Closed
davisjam opened this issue Sep 19, 2018 · 6 comments
Closed

Threadpool monitoring / metrics #22957

davisjam opened this issue Sep 19, 2018 · 6 comments
Labels
feature request Issues that request new features to be added to Node.js. libuv Issues and PRs related to the libuv dependency or the uv binding. stale

Comments

@davisjam
Copy link
Contributor

Is your feature request related to a problem? Please describe.

My (hypothetical) application uses the threadpool. Is the work performed in the threadpool the bottleneck for my application performance? This is hard to know at the moment.

Describe the solution you'd like

I would like API(s) to monitor the state of the threadpool.

Describe alternatives you've considered

Since the threadpool is currently embedded in libuv without monitoring hooks (but see libuv #1528), monitoring is not easy to do.

I think a monitoring API would be a logical thing to include within or following #22631.

I would like community input on what the API should look like and what metrics people would find valuable.

@jasnell
Copy link
Member

jasnell commented Sep 19, 2018

See: libuv/libuv#1815

@Trott
Copy link
Member

Trott commented Apr 22, 2020

@davisjam Is this still something you'd like to discuss? Or is this something that should likely be closed at this point?

@jasnell
Copy link
Member

jasnell commented Apr 22, 2020

@trevnorris is working on a pr to libuv that would add a critical metric and the mechanism to add more. Once that lands I think this is something we could move forward on

@davisjam
Copy link
Contributor Author

@Trott

I think it's still a valuable feature for Node. I am planning to direct some students towards these questions in the fall.

@jasnell jasnell added feature request Issues that request new features to be added to Node.js. libuv Issues and PRs related to the libuv dependency or the uv binding. labels Jun 26, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. libuv Issues and PRs related to the libuv dependency or the uv binding. stale
Projects
None yet
Development

No branches or pull requests

3 participants