Remove util.inherits usage internally?

[joyeecheung]

Currently, util.inherits does this:

node/lib/util.js

Lines 300 to 318 in e1aa730

	function inherits(ctor, superCtor) {
	if (ctor === undefined || ctor === null)
	throw new ERR_INVALID_ARG_TYPE('ctor', 'Function', ctor);
	if (superCtor === undefined || superCtor === null)
	throw new ERR_INVALID_ARG_TYPE('superCtor', 'Function', superCtor);
	if (superCtor.prototype === undefined) {
	throw new ERR_INVALID_ARG_TYPE('superCtor.prototype',
	'Function', superCtor.prototype);
	}
	Object.defineProperty(ctor, 'super_', {
	value: superCtor,
	writable: true,
	configurable: true
	});
	Object.setPrototypeOf(ctor.prototype, superCtor.prototype);
	}

Most of the code seems unnecessary for our internal use. Essentially we can just replace all the internal util.inherits usage with Object.setPrototypeOf(ctor.prototype, superCtor.prototype)

Unless someone is relying on that ctor._super property existing on our internal types..

Any thoughts?

[refack]

I'm +1 on writing a PR and running CitGM on it, then have it in nightlies go get some feedback. Otherwise we won't know.
(Ohh, and run a query on Gzemnid)

[joyeecheung]

This is still open, can probably be used as code-and-learn tasks

[ghost]

If the issue is still open, I'd be interested in looking into this?

[cjihrig]

@peanutenthusiast check out #26546 for an updated version of this issue.

[BridgeAR]

Closing as resolved. There is no usage internal usage left in core.