Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove `inherits()` usage #25245

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 28, 2018

This switches all util.inherits() calls to use Object.setPrototypeOf() instead in the test dir.

Only the test-util-inherits is preserve since util.inherits() isn't removed entirely.

Refs: #24755 #24395

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

Landed in 2f981cd

@Trott Trott closed this Dec 31, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 31, 2018
test: remove `util.inherits()` usage
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@ZYSzys ZYSzys deleted the zys-contribs:test-remove-util-inherits branch Dec 31, 2018

targos added a commit that referenced this pull request Jan 1, 2019
test: remove `util.inherits()` usage
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove `util.inherits()` usage
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
ZYSzys added a commit to zys-contribs/node that referenced this pull request Jul 21, 2019
test: remove `util.inherits()` usage
PR-URL: nodejs#25245
Refs: nodejs#24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ZYSzys ZYSzys referenced this pull request Jul 21, 2019
3 of 3 tasks complete
BethGriggs added a commit that referenced this pull request Jul 26, 2019
test: remove `util.inherits()` usage
Backport-PR-URL: #28795
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.