Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-child-process-pipe-dataflow failing on Windows #48300

Open
aduh95 opened this issue Jun 2, 2023 · 10 comments
Open

test-child-process-pipe-dataflow failing on Windows #48300

aduh95 opened this issue Jun 2, 2023 · 10 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@aduh95
Copy link
Contributor

aduh95 commented Jun 2, 2023 

not ok 106 parallel/test-child-process-pipe-dataflow
  ---
  duration_ms: 221.12800
  severity: fail
  exitcode: 1
  stack: |-
    node:assert:125
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected
    
    + '130086'
    - '1048577'
        at process.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-child-process-pipe-dataflow.js:71:12)
        at process.emit (node:events:523:35) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: '130086',
      expected: '1048577',
      operator: 'strictEqual'
    }
    
    Node.js v21.0.0-pre
  ...

It's also failing on v16.x-staging, so I don't think it's related to a recent change on main, maybe a change with the infra?
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 2, 2023 •
edited

Examples:

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 2, 2023

/cc @nodejs/platform-windows @nodejs/build

@aduh95 aduh95 added windows Issues and PRs related to the Windows platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jun 2, 2023
@lpinca lpinca mentioned this issue Jun 3, 2023
Merged
@StefanStojanovic StefanStojanovic mentioned this issue Jun 3, 2023
Closed
@MoLow
Copy link
Member

MoLow commented Jun 4, 2023

I am investigating on https://ci.nodejs.org/computer/test-azure_msft-win11_vs2022-arm64-3/

This was referenced Jun 4, 2023
Closed
Merged
@richardlau
Copy link
Member

It's also failing on v16.x-staging, so I don't think it's related to a recent change on main, maybe a change with the infra?

Looking at the Node.js 16 daily builds, the first failure there appears to be https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-v16.x-staging/36/, i.e. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/21215/. Those failures happened on:

According to #48331, the test is failing due to a difference in behaviour of wc. I believe wc is coming from git.

Looking at the prior windows-update-reboot run before those jobs we can see that git was updated
e.g. https://ci.nodejs.org/manage/computer/test-azure_msft-win10_vs2019-x64-4/builds
https://ci.nodejs.org/job/windows-update-reboot/label=test-azure_msft-win10_vs2019-x64-4/2370/consoleFull

09:00:37 
09:00:37 You have git v2.40.1 installed. Version 2.41.0 is available based on your source(s).
09:00:53 
Progress: Downloading git.install 2.41.0... %
...
Progress: Downloading git.install 2.41.0... 100%
09:00:56 
09:00:56 git.install v2.41.0 [Approved]
09:00:56 git.install package files upgrade completed. Performing other installation steps.
09:00:57 Using Git LFS
09:00:57 Installing 64-bit git.install...
09:01:28 git.install has been installed.
09:01:28 git.install installed to 'C:\Program Files\Git'
09:01:28   git.install can be automatically uninstalled.
09:01:29  The upgrade of git.install was successful.
09:01:29   Software installed to 'C:\Program Files\Git\'
09:01:33 
Progress: Downloading git 2.41.0... 62%
Progress: Downloading git 2.41.0... 100%
09:01:33 
09:01:33 git v2.41.0 [Approved]
09:01:33 git package files upgrade completed. Performing other installation steps.
09:01:33  The upgrade of git was successful.
09:01:33   Software installed to 'C:\ProgramData\chocolatey\lib\git'
09:01:34 git.install v2.41.0 is the latest version available based on your source(s).

(Similarly https://ci.nodejs.org/job/windows-update-reboot/label=test-rackspace-win2012r2_vs2017-x64-4/2370/consoleFull for the other machine.)

@bricss
Copy link

bricss commented Jun 5, 2023

It's might be due to latest Git 64-bit version switch to Cygwin v3.4.0 -> https://gitforwindows.org/32-bit.html

@lpinca
Copy link
Member

lpinca commented Jun 6, 2023

I can confirm that the issue is caused by Git for Windows v2.41.0. With v2.40.0 the test passes locally.

@juanarbol juanarbol mentioned this issue Jun 7, 2023
Closed
@richardlau
Copy link
Member

Probably related to git-for-windows/git#4464

@lpinca
Copy link
Member

lpinca commented Jun 23, 2023 •
edited

I've also seen test-child-process-stdio-reuse-readable-stdio fail recently on Windows and I think the underlying issue is the same.

lpinca added a commit to lpinca/node that referenced this issue Jun 24, 2023
@lpinca
test: mark test-child-process-stdio-reuse-readable-stdio flaky
90f4bb1 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
@lpinca lpinca mentioned this issue Jun 24, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Jun 25, 2023
@lpinca
test: mark test-child-process-stdio-reuse-readable-stdio flaky
c308054 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: #48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this issue Jun 29, 2023
@lpinca @juanarbol
test: mark test-child-process-stdio-reuse-readable-stdio flaky
5daa07a 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this issue Jul 3, 2023
@lpinca @RafaelGSS
test: mark test-child-process-stdio-reuse-readable-stdio flaky
0f912a7 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: #48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol pushed a commit that referenced this issue Jul 4, 2023
@lpinca @juanarbol
test: mark test-child-process-stdio-reuse-readable-stdio flaky
2edd0fd 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #48537
richardlau pushed a commit that referenced this issue Jul 11, 2023
@lpinca @richardlau
test: mark test-child-process-stdio-reuse-readable-stdio flaky
859aa87 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: #48537
Backport-PR-URL: #48650
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@lpinca
Copy link
Member

lpinca commented Aug 14, 2023

The upstream issue was closed without a fix.

Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@lpinca @Ceres6
test: mark test-child-process-stdio-reuse-readable-stdio flaky
5f92b46 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
@lpinca @Ceres6
test: mark test-child-process-stdio-reuse-readable-stdio flaky
4339923 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@joyeecheung
Copy link
Member

It's almost constantly failing now, perhaps we should just skip it on Windows until it's properly fixed to at least give the CI some green space..

@joyeecheung joyeecheung mentioned this issue Sep 8, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Sep 11, 2023
@joyeecheung
test: skip test-child-process-pipe-dataflow.js on Windows
b0edb28 
This is constantly failing on Windows now that the CI is never green
there. To give CI at least some green space, mark it as SKIP, because
we've been practically ignoring the failure for months anyway, and
will probably just continue doing that.

PR-URL: #49563
Refs: #48300
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
ruyadorno pushed a commit that referenced this issue Sep 28, 2023
@joyeecheung @ruyadorno
test: skip test-child-process-pipe-dataflow.js on Windows
667a924 
This is constantly failing on Windows now that the CI is never green
there. To give CI at least some green space, mark it as SKIP, because
we've been practically ignoring the failure for months anyway, and
will probably just continue doing that.

PR-URL: #49563
Refs: #48300
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@joyeecheung @alexfernandez
test: skip test-child-process-pipe-dataflow.js on Windows
3890a1b 
This is constantly failing on Windows now that the CI is never green
there. To give CI at least some green space, mark it as SKIP, because
we've been practically ignoring the failure for months anyway, and
will probably just continue doing that.

PR-URL: nodejs#49563
Refs: nodejs#48300
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this issue May 5, 2024
@lpinca @StefanStojanovic
test: mark test-child-process-stdio-reuse-readable-stdio flaky
f42996e 
Refs: nodejs/node#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs/node#48537
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-child-process-pipe-dataflow MoLow/node
6 participants
@lpinca @bricss @joyeecheung @richardlau @MoLow @aduh95