Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage-windows workflow is disabled #50049

Closed
targos opened this issue Oct 5, 2023 · 4 comments
Closed

coverage-windows workflow is disabled #50049

targos opened this issue Oct 5, 2023 · 4 comments
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.

Comments

@targos
Copy link
Member

targos commented Oct 5, 2023

https://github.com/nodejs/node/actions/workflows/coverage-windows.yml

See #49639

It had to be done so we're able to land the latest V8 upgrade.

The job fails because the vm runs out of disk space during execution of the tests.

Example: https://github.com/nodejs/node/actions/runs/6310149819/job/17178038061?pr=49639

@targos targos added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 5, 2023
@shnooshnoo
Copy link

I just forked node and tried running this action several times - all the runs were successful. Perhaps the issue whatever it was is now fixed and this action can be enabled again?

@targos
Copy link
Member Author

targos commented Jan 23, 2024

Thanks for trying. I just enabled it again. Let's monitor next runs on https://github.com/nodejs/node/actions/workflows/coverage-windows.yml

@merceyz
Copy link
Member

merceyz commented Jan 23, 2024

The GitHub hosted runners recently got more storage so that might explain it;

[...] we now provide machines that are double their previous specification, with 4-vCPUs, 16 GiB of memory, and 150GiB storage.
[...] the new machines offer twice the memory and over 10x the amount of storage than before.
https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/

@targos
Copy link
Member Author

targos commented Jan 24, 2024

I see only green runs since yesterday, so I'll optimistically close this issue.
Thanks again @shnooshnoo for looking into it and @merceyz for the reference!

@targos targos closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

3 participants