Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Intl: ICU 58 bump #7844

Closed
srl295 opened this issue Jul 22, 2016 · 25 comments
Closed

deps: Intl: ICU 58 bump #7844

srl295 opened this issue Jul 22, 2016 · 25 comments
Assignees
Labels
i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. wip Issues and PRs that are still a work in progress.

Comments

@srl295
Copy link
Member

srl295 commented Jul 22, 2016

ICU 58 shipped 2016-Oct-21 - http://site.icu-project.org/download/58

@srl295
Copy link
Member Author

srl295 commented Jul 22, 2016

fyi @ofrobots

@srl295
Copy link
Member Author

srl295 commented Jul 22, 2016

I had no functional problems getting ICU58m1 to run in srl295@770a5ff (big commit)

License file needs work, but I already have todos on that…

If anyone is curious how git manages such an upgrade:

[icu4c-58m1 770a5ff] *NOT FOR MERGING OR PRODUCTION* — experimental build of icu4c 58m1
 Date: Fri Jul 22 12:34:27 2016 -0700
 894 files changed, 17720 insertions(+), 14946 deletions(-)
 rewrite deps/icu-small/source/common/ubidi_props_data.h (66%)
 rewrite deps/icu-small/source/common/ucase_props_data.h (72%)
 rewrite deps/icu-small/source/common/uchar_props_data.h (86%)
 rename deps/icu-small/source/data/in/{icudt57l.dat => icudt58l.dat} (65%)

(edit- this is a fixed commit… I had committed with the wrong line endings before, which bloated the diffs unsurprisingly)

this script says that the commit is 10,832,068 bytes.

Also, on macOS the binary size of node increased by 48,568 bytes with this commit.

We did do a copyright change (but the license is the same MIT/X) in this rev, so it's probably larger than normal.

@mscdex mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Jul 22, 2016
@srl295 srl295 self-assigned this Jul 22, 2016
@srl295
Copy link
Member Author

srl295 commented Jul 22, 2016

So at this point there's nothing known that needs updating to allow use of ICU 58 when it comes out. I'll leave this open for the actual commit later this year.

@srl295
Copy link
Member Author

srl295 commented Jul 22, 2016

ICU 58 is planning to:

  • upgrade project files to VS 2015 (no effect on Node)
  • require C++11 for c++ code compiled against ICU

@Fishrock123 Fishrock123 added the wip Issues and PRs that are still a work in progress. label Jul 22, 2016
@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

@srl295 ... when in october is 58 expected to be released?

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

require C++11 for c++ code compiled against ICU

This one may be a challenge. Will C++11 be required to build ICU in our tree?

@addaleax
Copy link
Member

addaleax commented Aug 9, 2016

@jasnell Node’s own code does use C++11 features, fwiw.

@ofrobots
Copy link
Contributor

ofrobots commented Aug 9, 2016

This one may be a challenge. Will C++11 be required to build ICU in our tree?

Depends on the timing. V8 LKGR also requires C++11 now.

@srl295
Copy link
Member Author

srl295 commented Aug 9, 2016

@jasnell right, I understood from @mhdawson that c++11 features required elsewhere were already hitting issues.
from http://icu-project.org :

2016-09-15: 58 Release Candidate
2016-10-01: 58 Release (58.1)

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

Yeah, I've seen it a few times. I guess with v7 we'll just have to make the c++11 requirement official.

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

@addaleax ... oh! oy! ... I'd completely missed that ;-) carry on then lol

@mhdawson
Copy link
Member

Yes our work on a Z/OS port is being affected by the c+11 feature requirements.

@ofrobots
Copy link
Contributor

@mhdawson Can you elaborate on your statement.. Do you want to use C++11 features but can't, or is the z/OS port being hindered by the features already in use in the code?

@mhdawson
Copy link
Member

The issue is that the C+11 features already used by Node.js/v8 are not fully supported by the compiler on Z/OS which is the "hinderance". The compiler will be updated but won't be ready until some time in the future. So its not a new problem just confirmation that the problem already exists.

@rvagg
Copy link
Member

rvagg commented Aug 31, 2016

From the [linked trac ticket]:

We just decided to permit any C++11 feature if every compiler except for “Digital Mars C++” (former Zortech C++/Symantec C++) supports it

That's a very wide definition because it doesn't talk about versions at all. Thankfully HP aCC is holding back the feature set but it'd be nice if they had some minimum version requirements in that, such as "gcc 4.8" (our minimum).

@srl295
Copy link
Member Author

srl295 commented Aug 31, 2016

@rvagg I think we (Icu) will become more crisp on this. That statement did not mention versions but we will list versions as we get closer to rc. Point taken though.

@srl295
Copy link
Member Author

srl295 commented Sep 20, 2016

FYI- ICU 58 won't require C++11

srl295 added a commit to srl295/node that referenced this issue Sep 20, 2016
ICU’s license file changed from `license.html` to `LICENSE`.
Fix `shrink-icu-src.py` (which is manually run) to accept either file.

Related to nodejs#7844 which is the 58 bump.
@srl295
Copy link
Member Author

srl295 commented Sep 20, 2016

I committed some trial merges of (not final!!) icu58 to a branch, above ^. please test if you are interested in this.

Delta: node binary increased 105k on mac. haven't tried to do anything special to trim at all. Probably will target zero-or-negative.

@jbergstroem
Copy link
Member

@srl295 any updates on the definition of "We just decided to permit any C++11 feature"?

@srl295 srl295 added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 21, 2016
@srl295 srl295 mentioned this issue Oct 22, 2016
4 tasks
@srl295
Copy link
Member Author

srl295 commented Oct 22, 2016

FWIW, I've bumped the data that backs the full-icu module to support 58.

@srl295
Copy link
Member Author

srl295 commented Oct 25, 2016

should be minor

On Wed, Oct 19, 2016 at 8:39 PM, James M Snell notifications@github.com
wrote:

@srl295 https://github.com/srl295 ... is the PR going to be
semver-major or semver-minor?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7844 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA0Ms2tGmgbnUafcniKYKk0sCO2eim1Xks5q1uJjgaJpZM4JTDcf
.

srl295 added a commit to srl295/node that referenced this issue Oct 31, 2016
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to nodejs#8674 )

Fixes: nodejs#7844
PR-URL: nodejs#9234
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this issue Oct 31, 2016
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: nodejs#7844
PR-URL: nodejs#9234
Reviewed-By: James M Snell <jasnell@gmail.com>
@srl295 srl295 closed this as completed in 03023fa Oct 31, 2016
srl295 added a commit that referenced this issue Oct 31, 2016
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue Nov 3, 2016
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue Nov 3, 2016
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this issue Jan 18, 2017
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to nodejs#8674 )

Fixes: nodejs#7844
PR-URL: nodejs#9234
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this issue Jan 18, 2017
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: nodejs#7844
PR-URL: nodejs#9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 20, 2017
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 20, 2017
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 31, 2017
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 31, 2017
This commit contains the ICU 58.1 delta.
It is especially large because of the ICU license change,
and, because the line endings were off previously.

* bump to ICU 58.1 - check in small ICU source
* from 58.1 final http://site.icu-project.org/download/58

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this issue May 9, 2017
* No feature changes.
* Bug fixes.
* Details: http://site.icu-project.org/download/59

Fixes: nodejs#12077
PR-URL: nodejs#12486
Refs: nodejs#7844
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
* No feature changes.
* Bug fixes.
* Details: http://site.icu-project.org/download/59

Fixes: nodejs#12077
PR-URL: nodejs#12486
Refs: nodejs#7844
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
srl295 added a commit to srl295/node that referenced this issue Jan 18, 2018
* No feature changes.
* Bug fixes.
* Details: http://site.icu-project.org/download/59

Fixes: nodejs#12077
PR-URL: nodejs#12486
Refs: nodejs#7844
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

No branches or pull requests

9 participants