Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the installer deleting my symlink for AppData\Roaming\npm #7882

Closed
leppie opened this issue Jul 26, 2016 · 5 comments
Closed

Stop the installer deleting my symlink for AppData\Roaming\npm #7882

leppie opened this issue Jul 26, 2016 · 5 comments
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. install Issues and PRs related to the installers. npm Issues and PRs related to the npm client dependency or the npm registry. stalled Issues and PRs that are stalled. windows Issues and PRs related to the Windows platform.

Comments

@leppie
Copy link

leppie commented Jul 26, 2016

Thank you

@mscdex mscdex added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jul 26, 2016
@joaocgreis
Copy link
Member

I haven't tried to reproduce, but that is most likely because the installer ensures that folder exists. This is also done in npm, but in the past we had issues where npm couldn't create the folder because of permissions, and creating it in the installer solves the problem in those cases.

Perhaps we could add a custom action to check if a symlink already exists, or make crating the folder an optional item in the features to install, and default to off when updating. I'll add this to my queue but it might be a while before I get to it, feel free to open a PR if you want to.

Thanks for reporting!

@joaocgreis joaocgreis added the good first issue Issues that are suitable for first-time contributors. label Aug 2, 2016
@JungMinu JungMinu self-assigned this Aug 9, 2016
@ALJCepeda
Copy link
Contributor

Has there been any work done on this? If not I'd like to give it a shot

@JungMinu JungMinu removed their assignment Nov 4, 2016
@dave-k
Copy link
Contributor

dave-k commented Apr 28, 2017

@ALJCepeda are working this issue?

I would like to give it a try if no-one is working on this.

@dave-k
Copy link
Contributor

dave-k commented Apr 28, 2017

Do I need to be on windows to fix this? I'm on a Mac.

@refack
Copy link
Contributor

refack commented Apr 28, 2017

@dave-k, you'd probably need Windows, since the problem is with the windows installer.
The installer code is here https://github.com/nodejs/node/tree/master/tools/msvs/msi
You could try to sketch something, but for a PR we usually expect some testing to be done beforehand.
If you make progress and need help testing you can ping me (I run on Windows).

@Trott Trott added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. and removed good first issue Issues that are suitable for first-time contributors. labels Aug 6, 2017
@targos targos added the stalled Issues and PRs that are stalled. label Nov 4, 2018
@jasnell jasnell closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. install Issues and PRs related to the installers. npm Issues and PRs related to the npm client dependency or the npm registry. stalled Issues and PRs that are stalled. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

10 participants